refactor: add precise parameter types to Router test fixtures - #10464
Open
soccerlover29 wants to merge 2 commits into
Open
refactor: add precise parameter types to Router test fixtures#10464soccerlover29 wants to merge 2 commits into
soccerlover29 wants to merge 2 commits into
Conversation
paulbalandan
approved these changes
Aug 16, 2026
Member
|
Hi @soccerlover29 , instead of hand-editing the baseline files, could you run |
This comment was marked as outdated.
This comment was marked as outdated.
soccerlover29
force-pushed
the
fix/router-test-fixture-param-types
branch
from
August 18, 2026 15:01
ebc0d09 to
7a32d3f
Compare
Contributor
Author
|
The 2 failing lint checks (PHP 8.2 Lint with PHP CS Fixer / PHP 8.5 Lint with PHP CS Fixer) appear to be unrelated to this PR, since the reported violation is in tests/system/Validation/ValidationTest.php, which this PR doesn't touch. I checked out a clean copy of develop (no changes from this PR) and ran the same check locally with PHP CS Fixer 3.95.18, and it passes with 0 violations. The CI run used 3.95.19. Looks like a formatting-rule change between those two patch versions is flagging code that was previously considered compliant, independent of anything in this diff. |
paulbalandan
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds specific parameter types to 10 methods across the Router test fixtures and helper classes, replacing untyped parameters that PHPStan flagged as "no type specified." All changes are in test-only files. I tested it by running a full-project PHPStan scan and all the relevant tests.
Contributes to #7731 (PHPStan "no type specified" errors).
Checklist: