feat(pr-workflow): add the pull request loop plugin, and sync the marketplace versions - #2
Open
kaiomagalhaes wants to merge 1 commit into
Open
feat(pr-workflow): add the pull request loop plugin, and sync the marketplace versions#2kaiomagalhaes wants to merge 1 commit into
kaiomagalhaes wants to merge 1 commit into
Conversation
…ketplace versions Adds pr-workflow, a plugin of five skills that make one pull request loop: write the pull request, review it, answer the review, and record deferred work. Also fixes a distribution bug: marketplace.json advertised qa-check 3.1.0 with the v3 description, while plugin.json and SKILL.md were both 4.0.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pr-workflow, a plugin of five skills that make one pull request loop: write the pull request, review it, answer the review, and record the work that you defer. The skills come from a production repository; this version removes the paths, the tooling, and the domain of that repository, so that they work in any git repository. It also fixes a distribution bug that PR #1 introduced:marketplace.jsonadvertised qa-check 3.1.0 with the v3 description, butplugin.jsonandSKILL.mdare both 4.0.0, soclaude plugin installshowed stale metadata.Changes
plugins/pr-workflow
pr-createreads the branch diff, writes a title and a description, and opens the pull request. It finds the default branch withgh repo viewinstead of assumingmain, reads.github/PULL_REQUEST_TEMPLATE.mdon each run, and proposes a split into stacked pull requests above 20 files.pr-create-reviewedopens a draft, fans out to subagents that get only the pull request number, the diff, and their lens, presents one findings table, and marks the pull request ready. The isolation is the point: a reviewer that inherits the reasoning of the author agrees with it.review-prexamines a pull request across code quality, security, and the rules of the repository. It prints the review for your own pull request and posts inline comments on a pull request from a different author, after you approve them.pr-address-commentsreads all three GitHub comment APIs, because inline comments, top-level comments, and review summaries are three different surfaces, and uses GraphQL to skip resolved threads.issue-createlearns the title, label, and body conventions from the issues that exist, instead of applying a fixed template.Repository
marketplace.json: qa-check moves from 3.1.0 to 4.0.0, and its description now matchesplugin.json. The marketplace metadata moves to 1.3.0.README.md: the install command and the skill table list the new plugin. The copy instruction says that the five skills ship as one plugin, because they call each other.Implementation Details
pr-create-revieweddelegates its title and description topr-create, and both it andreview-prread the samereview-criteria.md. Separate plugins would let a user install half of a loop and break those links.gh repo viewfor the default branch,ls .claude/agents/for the specialist reviewers,gh label listfor the label taxonomy, andREVIEW.md,CLAUDE.md,AGENTS.md, orCONTRIBUTING.mdfor the rules. Where the source skill named an accounting invariant, the text names "the load-bearing domain of the repository" and tells the skill where to find it.--body-fileeverywhere. A finding or a description that contains a backtick or a single quotation mark breaks an inline--bodyargument. The GitHub review API path writes a JSON file with the Write tool, so that the tool escapes each string.Test Plan
*.jsonmanifests parses.SKILL.mdfrontmatter parses as YAML, and itsnamematches its directory name.marketplace.jsonandplugin.json, and the descriptions match. All three plugins agree.references/*.mdlink resolves from its skill directory, and this includes the cross-skill link frompr-create-reviewedto../review-pr/references/review-criteria.md.ghflag in the skills exists in gh 2.98.0:--body-fileonpr create,pr edit,pr comment,pr review, andissue create;--inputand-F key=@fileongh api.Notes
Risks:
pr-createandpr-create-reviewedtell the model to run/qa-checkbefore the push, andpr-createtells it to run/supply-chain-checkwhen a lock file changes. Each reference says "if the plugin is installed", so a user who installs onlypr-workflowis not blocked. A user who installs all three gets the full gate.review-pralso makes the model write its findings in ASD-STE100, which is a stronger claim, and is worth a read.Follow-ups:
🤖 Generated with Claude Code