Skip to content

🤖 tests: run eight loop test files on the SessionFiles memory layer - #7317

Merged
ThomasK33 merged 1 commit into
phase2/history-test-layersfrom
phase2/loop-tests-on-memory
Oct 23, 2026
Merged

ThomasK33 merged 1 commit into
phase2/history-test-layersfrom
phase2/loop-tests-on-memory

Conversation

@ThomasK33

@ThomasK33 ThomasK33 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Summary

Eight loop test files that touch no file themselves now build their HistoryService on the SessionFilesMemory layer. Only their own createTestHistoryService calls change; harness calls keep the Node layer. Test-only.

Background

Phase 2 of the agent-loop host-ports refactor puts HistoryService's node:fs calls behind an Effect service, SessionFiles, with a Node layer for the app and a memfs layer for tests. The change is behaviour-neutral: session files keep their bytes and format, downgrade keeps working, and nothing user-visible changes. This PR is one layer of a GitHub-native stack; each layer keeps the full suite green.

Implementation

agentSession.compactionContextExceeded, agentSession.postCompactionRefresh, agentSession.preStreamError, aiService.turnCompletion, contextManagement/compactionRequests, idleCompactionService, streamManager.chaos and streamManager.modelOnlyNotifications pass { files: SessionFilesMemory }. None of them imports fs or reads a session path, so no assertion depends on disk.

Validation

Risks

Low: test-only.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $30.26

@ThomasK33
ThomasK33 added this pull request to stack #7318 October 23, 2026 07:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T09:01:00.865777Z fa51108 New commits
🔒 Security Review ✅ Completed 2026-10-23T09:01:20.886225Z fa51108 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🟢 e2e stories (Haiku): 14 passed

27 agent steps · 7 replayed from cache · 31 model calls · 219.1k tokens (74% cached)
Spend: $0.09 of the $1.00 cap (proxy ledger)

All 14 tests in 9 files
Test Agent Time
🟢 chatRestart.e2e.ts · 1 passed 2 steps · 4 calls 25.3s
🟢 a chat survives a restart of the server 2 steps · 4 calls 25.3s
🟢 compaction.e2e.ts · 1 passed 3 steps · 7 calls 45.0s
🟢 /compact replaces the old chat with a summary 3 steps · 7 calls 45.0s
🟢 pluginTrustRestart.e2e.ts · 1 passed 4 steps · 2 calls 9.5s
🟢 a trusted plugin hook stays trusted after the server restarts 4 steps · 2 calls 9.5s
🟢 settingsRoundTrip.e2e.ts · 1 passed 3 steps · 5 calls 31.1s
🟢 a chat survives trips through Settings 3 steps · 5 calls 31.1s
🟢 sidebarPerWorkspace.e2e.ts · 1 passed 4 steps · 1 call 5.6s
🟢 a new workspace starts with its right sidebar collapsed while another keeps it open 4 steps · 1 call 5.6s
🟢 smoke.e2e.ts · 1 passed 2 steps · 1 call 2.9s
🟢 the agent opens the playground workspace 2 steps · 1 call 2.9s
🟢 streamErrors.e2e.ts · 1 passed 1 step · 1 call 8.0s
🟢 stream errors show in the chat, and the chat recovers 1 step · 1 call 8.0s
🟢 todoNudge.e2e.ts · 1 passed 2 steps · 4 calls 25.5s
🟢 the agent finishes open TODO items after the turn-end nudge 2 steps · 4 calls 25.5s
🟢 touchAlignment.e2e.ts · 6 passed 6 steps · 6 calls 24.8s
🟢 the Settings close button is level with the title on a touch screen 390px wide 1 step · 1 call 3.7s
🟢 the Settings close button is level with the title on a touch screen 768px wide 1 step · 1 call 4.3s
🟢 Backup settings checkboxes are small and level with their labels on a touch phone 1 step · 1 call 4.2s
🟢 the heartbeat checkbox is small and level with its label on a touch phone 1 step · 1 call 3.2s
🟢 a reply's model and time stay on one line on a touch phone 1 step · 1 call 6.4s
🟢 the workspace actions menu stays on the title row on a touch phone 1 step · 1 call 3.1s

e2e 0.20.0 · 3m 1s · web · run artifacts

🟢 e2e Electron stories (Haiku): 3 passed

3 agent steps · 3 model calls · 8.1k tokens (32% cached)
Spend: $0.01 of the $1.00 cap (proxy ledger)

All 3 tests in 3 files
Test Agent Time
🟢 electron/deepLink.e2e.ts · 1 passed 1 step · 1 call 5.6s
🟢 a deep link of a second launch starts a chat in the running app 1 step · 1 call 5.6s
🟢 electron/menuBar.e2e.ts · 1 passed 1 step · 1 call 5.5s
🟢 the workspace menu bar is the desktop title bar 1 step · 1 call 5.5s
🟢 electron/smoke.e2e.ts · 1 passed 1 step · 1 call 4.8s
🟢 Xum Electron opens the playground workspace 1 step · 1 call 4.8s

e2e 0.20.0 · 17.9s · electron · run artifacts

🟢 e2e agent repros (Haiku): no tests selected

Spend: $0.00 of the $1.00 cap (proxy ledger)

e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: b9256adb7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: b9256adb7c

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ThomasK33
ThomasK33 added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 23, 2026
@ThomasK33
ThomasK33 force-pushed the phase2/loop-tests-on-memory branch from b9256ad to fa51108 Compare October 23, 2026 08:59
@ThomasK33
ThomasK33 added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit c3bfde5 Oct 23, 2026
37 of 38 checks passed
@ThomasK33
ThomasK33 deleted the phase2/loop-tests-on-memory branch October 23, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant