Repository navigation
🤖 tests: run eight loop test files on the SessionFiles memory layer - #7317
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🟢 e2e stories (Haiku): 14 passed27 agent steps · 7 replayed from cache · 31 model calls · 219.1k tokens (74% cached) All 14 tests in 9 files
e2e 0.20.0 · 3m 1s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 8.1k tokens (32% cached) All 3 tests in 3 files
e2e 0.20.0 · 17.9s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
b9256ad to
fa51108
Compare
Summary
Eight loop test files that touch no file themselves now build their HistoryService on the
SessionFilesMemorylayer. Only their owncreateTestHistoryServicecalls change; harness calls keep the Node layer. Test-only.Background
Phase 2 of the agent-loop host-ports refactor puts HistoryService's
node:fscalls behind an Effect service,SessionFiles, with a Node layer for the app and a memfs layer for tests. The change is behaviour-neutral: session files keep their bytes and format, downgrade keeps working, and nothing user-visible changes. This PR is one layer of a GitHub-native stack; each layer keeps the full suite green.Implementation
agentSession.compactionContextExceeded,agentSession.postCompactionRefresh,agentSession.preStreamError,aiService.turnCompletion,contextManagement/compactionRequests,idleCompactionService,streamManager.chaosandstreamManager.modelOnlyNotificationspass{ files: SessionFilesMemory }. None of them importsfsor reads a session path, so no assertion depends on disk.Validation
idleCompactionServiceruns about 45% faster andstreamManager.chaosabout 32% faster; the others change by under 15%.src/node/services/sessionLocks/backendKill.test.ts("a SIGKILL in a turn recovers as today") can fail on a race that 🤖 tests: let the kill test wait until the new backend releases its turn #7320 fixes. A failed job gets one rerun.Risks
Low: test-only.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$30.26