Skip to content

🤖 perf: revert #7515 (status view lazy load added late sidebar requests) - #7521

Merged
ThomasK33 merged 1 commit into
mainfrom
perf/revert-7515
Oct 25, 2026
Merged

ThomasK33 merged 1 commit into
mainfrom
perf/revert-7515

Conversation

@ThomasK33

Copy link
Copy Markdown
Member

Summary

Reverts #7515. A same-session VM Lighthouse A/B shows it made the seeded workspace page slower on desktop: median LCP +72.5 ms (1615.0 -> 1687.5 ms, 6+6 ABBA, all runs quiet). The limit is +40 ms.

Background

#7515 made the status view lazy so the workspace page would stop loading the artifact frame (#7510). The seeded page also loads the right sidebar, and the right sidebar still imports the artifact stack (McpAppFrame.tsx:59 imports a constant from SandboxedArtifactFrame; RightSidebar shares useArtifactInteractions and the viewers). So the frame code still loads, only later: in the right-sidebar wave at about 335-380 ms instead of the early wave at about 150 ms, plus three new shared chunks (33 -> 36 requests, +5.8 KB script). LCP equals TTI in every run, so the later graph end moves LCP.

Details and per-run numbers: #7510 (comment)

Implementation

git revert 47d2e4df7d. ChatPane imports AgentInterfaceStatusView statically again, and the rendererFirstLoad.test.ts guard added by #7515 goes too (on main the guard is false again, so it would fail). #7510 is reopened; the next attempt fixes the sidebar importers first and gates on the seeded page's real request list plus a VM A/B.

Validation

  • make static-check passes locally.
  • Expected VM result after merge: seeded desktop back to the cf7b78bd55 level (about 1604-1615 ms), 33 requests.

Risks

Low. This restores the code that was on main until 19:43Z today. The status view (experiment-gated) behaves the same either way.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $1855.40

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T20:09:46.233136Z 352a95c PR opened
🔒 Security Review ✅ Completed 2026-10-25T20:12:13.077060Z 352a95c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 e2e stories (Haiku): 14 passed

27 agent steps · 7 replayed from cache · 31 model calls · 214.2k tokens (72% cached)
Spend: $0.09 of the $1.00 cap (proxy ledger)

All 14 tests in 9 files
Test Agent Time
🟢 chatRestart.e2e.ts · 1 passed 2 steps · 4 calls 24.0s
🟢 a chat survives a restart of the server 2 steps · 4 calls 24.0s
🟢 compaction.e2e.ts · 1 passed 3 steps · 7 calls 43.2s
🟢 /compact replaces the old chat with a summary 3 steps · 7 calls 43.2s
🟢 pluginTrustRestart.e2e.ts · 1 passed 4 steps · 2 calls 9.3s
🟢 a trusted plugin hook stays trusted after the server restarts 4 steps · 2 calls 9.3s
🟢 settingsRoundTrip.e2e.ts · 1 passed 3 steps · 4 calls 28.7s
🟢 a chat survives trips through Settings 3 steps · 4 calls 28.7s
🟢 sidebarPerWorkspace.e2e.ts · 1 passed 4 steps · 1 call 5.2s
🟢 a new workspace starts with its right sidebar collapsed while another keeps it open 4 steps · 1 call 5.2s
🟢 smoke.e2e.ts · 1 passed 2 steps · 1 call 2.7s
🟢 the agent opens the playground workspace 2 steps · 1 call 2.7s
🟢 streamErrors.e2e.ts · 1 passed 1 step · 1 call 6.5s
🟢 stream errors show in the chat, and the chat recovers 1 step · 1 call 6.5s
🟢 todoNudge.e2e.ts · 1 passed 2 steps · 5 calls 23.3s
🟢 the agent finishes open TODO items after the turn-end nudge 2 steps · 5 calls 23.3s
🟢 touchAlignment.e2e.ts · 6 passed 6 steps · 6 calls 26.1s
🟢 the Settings close button is level with the title on a touch screen 390px wide 1 step · 1 call 8.1s
🟢 the Settings close button is level with the title on a touch screen 768px wide 1 step · 1 call 4.1s
🟢 Backup settings checkboxes are small and level with their labels on a touch phone 1 step · 1 call 4.6s
🟢 the heartbeat checkbox is small and level with its label on a touch phone 1 step · 1 call 3.4s
🟢 a reply's model and time stay on one line on a touch phone 1 step · 1 call 3.1s
🟢 the workspace actions menu stays on the title row on a touch phone 1 step · 1 call 2.8s

e2e 0.20.0 · 2m 52s · web · run artifacts

🟢 e2e Electron stories (Haiku): 3 passed

3 agent steps · 3 model calls · 8.0k tokens (32% cached)
Spend: $0.01 of the $1.00 cap (proxy ledger)

All 3 tests in 3 files
Test Agent Time
🟢 electron/deepLink.e2e.ts · 1 passed 1 step · 1 call 5.0s
🟢 a deep link of a second launch starts a chat in the running app 1 step · 1 call 5.0s
🟢 electron/menuBar.e2e.ts · 1 passed 1 step · 1 call 5.4s
🟢 the workspace menu bar is the desktop title bar 1 step · 1 call 5.4s
🟢 electron/smoke.e2e.ts · 1 passed 1 step · 1 call 4.8s
🟢 Xum Electron opens the playground workspace 1 step · 1 call 4.8s

e2e 0.20.0 · 17.3s · electron · run artifacts

🟢 e2e agent repros (Haiku): no tests selected

Spend: $0.00 of the $1.00 cap (proxy ledger)

e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts

@ThomasK33

Copy link
Copy Markdown
Member Author

Perf owner: merge record for #7521.

  1. Final commit 352a95c256 (exact inverse of 47d2e4df7d; no later main commit touches its two files). All checks pass, including Required. Codex code and security reviews completed with no findings (👍). 0 threads. Codex rounds: 1.
  2. Reason: VM A/B runs-ab/20261025T195728Z, seeded desktop median LCP +72.5 ms with 🤖 perf: load the agent interface status view only with the view #7515 (limit +40). Cause and next plan: 🤖 perf: the workspace page loads the artifact frame chunk since #7455 (seeded desktop LCP +40 ms) #7510 issuecomment-6402552008.
  3. Independent advisor (clean context): ready with tracked follow-ups. Follow-up = 🤖 perf: the workspace page loads the artifact frame chunk since #7455 (seeded desktop LCP +40 ms) #7510 (owner: perf owner; next attempt gates on the seeded page's request list and a VM A/B before merge).

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high

@ThomasK33
ThomasK33 added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit ce3940b Oct 25, 2026
34 checks passed
@ThomasK33
ThomasK33 deleted the perf/revert-7515 branch October 25, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant