Repository navigation
🤖 perf: revert #7515 (status view lazy load added late sidebar requests) - #7521
Conversation
This reverts commit 47d2e4d.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🟢 e2e stories (Haiku): 14 passed27 agent steps · 7 replayed from cache · 31 model calls · 214.2k tokens (72% cached) All 14 tests in 9 files
e2e 0.20.0 · 2m 52s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 8.0k tokens (32% cached) All 3 tests in 3 files
e2e 0.20.0 · 17.3s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts |
|
Perf owner: merge record for #7521.
Generated with |
Summary
Reverts
#7515. A same-session VM Lighthouse A/B shows it made the seeded workspace page slower on desktop: median LCP +72.5 ms (1615.0 -> 1687.5 ms, 6+6 ABBA, all runs quiet). The limit is +40 ms.Background
#7515made the status view lazy so the workspace page would stop loading the artifact frame (#7510). The seeded page also loads the right sidebar, and the right sidebar still imports the artifact stack (McpAppFrame.tsx:59imports a constant fromSandboxedArtifactFrame; RightSidebar sharesuseArtifactInteractionsand the viewers). So the frame code still loads, only later: in the right-sidebar wave at about 335-380 ms instead of the early wave at about 150 ms, plus three new shared chunks (33 -> 36 requests, +5.8 KB script). LCP equals TTI in every run, so the later graph end moves LCP.Details and per-run numbers: #7510 (comment)
Implementation
git revert 47d2e4df7d. ChatPane importsAgentInterfaceStatusViewstatically again, and therendererFirstLoad.test.tsguard added by#7515goes too (on main the guard is false again, so it would fail).#7510is reopened; the next attempt fixes the sidebar importers first and gates on the seeded page's real request list plus a VM A/B.Validation
make static-checkpasses locally.cf7b78bd55level (about 1604-1615 ms), 33 requests.Risks
Low. This restores the code that was on main until 19:43Z today. The status view (experiment-gated) behaves the same either way.
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$1855.40