feat(Casts): delegate null handling to custom casts - #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BooleanCastFixes #275.
This incorporates the core direction discussed in #276 while adding BooleanCast compatibility and tests.
Test-first reproduction
Before the implementation,
allows custom casts to handle null database valuesfailed because the custom cast received no opportunity to transform the null value (expectedcasted-null, received an empty string). The test passes after the change.The BooleanCast regression is covered through the normal Quick entity flow: load the nullable column with
find(), read it through the entity null/accessor APIs, update an unrelated attribute, refresh, and verify the Boolean attribute remains null.Verification
qb@beresolved locally to14.0.0-beta.3box run-script format:checkgit diff --check