Clarify that create returns a separate entity - #290
Closed
elpete wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Moved to the canonical Quick documentation repository as ortus-docs/quick-docs#64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #245
Issue review
This is a useful and accurate documentation improvement.
BaseEntity.create()is a factory-style convenience method: it callsnewEntity(), fills that new instance, saves it, and returns it. Callingcreate()does not mutate or load the receiver. That distinction is easy to miss and can leave application variables pointing at an unloaded entity.Recommendation: 9/10 — document explicitly.
Reasons for:
Tradeoffs:
ortus-docs/quick-docsrepository on version branches; that repository has nonextbranchnext, while the same wording should be carried to the versioned GitBook source when documentation is publishedImplementation
The
BaseEntity.create()documentation now states that it always creates and returns a separate instance, does not mutate the receiver, and shows assigning the return value.A public API integration test demonstrates the exact concern from the issue:
No runtime behavior was changed.
Validation
git diff --checkpassed