Support upserts through Quick entity queries - #334
Open
elpete wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Issue review
Recommendation: 9/10 — implement. Upsert is a useful bulk persistence primitive and qb provides the database-specific SQL safely. Quick should expose it as an explicit entity-query operation so the mutation cannot bypass Quick's entity metadata.
Quick semantics
upsert()now behaves likeupdateAll():QuickBuilderrather than relying on missing-method forwardingforce = trueprovides the same explicit escape hatch asupdateAlltoSql = true)The QuickQB wrapper remains responsible for the qb 14 signature, including
matchNulls, constraineddeleteUnmatched, and QuickBuilder sources.Test-first evidence
The public entity-query regression was added before the implementation. It failed because upserting through a read-only Quick entity did not throw
QuickReadOnlyException. Coverage now verifies:firstNametofirst_name)forceescape hatchValidation
updateAll, and read-only suites: 26 passed, 0 failed, 0 errorsgit diff --checkpassedUses the currently resolved qb 14 beta (
14.0.0-beta.3).