Repository navigation
fix: guard against invalid handle (0) in close() - #216
Merged
Merged
Conversation
Contributor
Author
|
Friendly ping — any updates? Happy to address feedback. |
Collaborator
|
thx see latest version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OSError raised in
__del__when no PicoScope device is connected.Problem: When instantiating
ps2000.PS2000()with no device connected,ps2000_open_unit()returns 0. This setsself.handle = 0. Inclose(), the checkif self.handle is not None:evaluates to True (since 0 is not None), so it calls_lowLevelCloseUnit(0)→ returns 0 →checkResult(0)→ raises OSError in__del__.Fix: Change
if self.handle is not None:toif self.handle:inpicobase.py. This treats both None and 0 (and any falsy value) as "not a valid connection", skipping the close call.Testing
python3 -m py_compile picoscope/picobase.py✅Fixes #214