Skip to content

fix: cache key ignores arch, latest never invalidates cache - #3

Merged
zeroshade merged 2 commits into
columnar-tech:mainfrom
amoeba:fix/cache-key-issue
Oct 28, 2026
Merged

zeroshade merged 2 commits into
columnar-tech:mainfrom
amoeba:fix/cache-key-issue

Conversation

@amoeba

@amoeba amoeba commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

This pull request fixes two separate bugs with the setup-dbc action:

  1. The cache key didn't automatically take into account runner architecture which caused runners to potentially pull cached versions from a runner with a different architecture. The fix here is to include runner architecture in the automatically computed cache key.
  2. When the workflow user specifies a version of latest. This works on the first run of the workflow, but because latest never changes, they get a permanently cached copy of dbc until they invalidate their cache some other way. The fix I went with was to determine the latest version by querying the GitHub release URL. This avoids an API call which could be rate limited but is a bit hacky because it parses the version from an HTTP header. We could possibly host something on the CDN that's more suited for this purpose.

This PR also fixes a minor bug in the caching test CI job. Caching only gets calculated at the end of a job so triggering the workflow twice in the same job to test it doesn't work. The fix is to run each invocation of the workflow in separate jobs.

@amoeba
amoeba requested a review from zeroshade October 27, 2026 21:37
@zeroshade
zeroshade merged commit 529191f into columnar-tech:main Oct 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants