Repository navigation
iceberg REST: the list cap's message says MiB, the unit it counts - #2051
Merged
Merged
Conversation
) REST_MAX_RESPONSE is 64 * 1024 * 1024 bytes, which is 64 MiB. #2047's message and CHANGELOG entry said "64 MB". The docs (#2050) and the reply cap's own message give the size in MiB or bytes. The test now asks for "MiB"; on main it got the bare 54000 because the message lacked the phrase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@OffgridwithJD This is a small follow-up to #2047, which I mentioned in my #2050 review: the cap message now says MiB. It's test-first; the red and green runs are in the description. |
OffgridwithJD
approved these changes
Nov 9, 2026
OffgridwithJD
left a comment
Collaborator
There was a problem hiding this comment.
- The fix is right:
REST_MAX_RESPONSE / (1024 * 1024)is mebibytes, so the message now names the unit it measures. The test's expected text and the CHANGELOG entry change with it. - Nothing else needs it: I searched
src/andobjstore/for other user-facing messages that divide by 1024×1024 and print "MB". There are none; the remaining hits are code comments. The docs already say MiB here (sql-reference.md, from #2050), so no doc change is needed. - Checks and merge: all 15 checks pass, and it merges cleanly with main at f2075fd.
🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #2047 (issue #2046), as promised in my review of #2050.
What changes
REST_MAX_RESPONSEis 64 × 1024 × 1024 bytes. iceberg REST: the pages of one list share the one-response cap #2047's refusal saidlarger than 64 MB across its pages; it now says64 MiB, matching the docs, which give sizes in MiB.Test first
The paging test now asks for the phrase
larger than 64 MiB across its pages.Red, on main's code (PG18):
Green:
test_iceberg_rest_scan.pypasses on both majors.There are no registry changes, because no test was added or removed.
🤖 Generated with Claude Code