Repository navigation
[cppjit] Keep LD_LIBRARY_PATH from the environment in the tests [ROOT-patch] - #165
Merged
aaronj0 merged 1 commit intoOct 23, 2026
Conversation
Collaborator
|
Can you open this against main instead of the ROOT branch? That can be tested and landed as a standard patch. |
Contributor
Author
|
Done |
Collaborator
Changing the base branch keeps all the commits before 4232cd2, you'll need to rewrite the history with a cherry pick on main |
Contributor
Author
|
Ah yes, there is no |
jmcarcell
force-pushed
the
tests-ld-library-path
branch
from
October 22, 2026 18:54
7afae94 to
c05a55c
Compare
Collaborator
Ah, right. No worries we can merge this as is. Can you target ROOT-2026-10-21 (https://github.com/compiler-research/cppjit/tree/ROOT-2026-10-21) |
aaronj0
force-pushed
the
tests-ld-library-path
branch
from
October 23, 2026 10:01
c05a55c to
6eef4de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
The cppjit tests in ROOT set
LD_LIBRARY_PATHto only the test directory, replacing the one from the environment. When ROOT is built with a compiler whose C++ standard library is found throughLD_LIBRARY_PATH, as with the LCG views, every cppjit test fails before running:or
Changes or fixes:
Prepend the test directory to the
LD_LIBRARY_PATHof the environment instead of replacing it, the same wayPYTHONPATHis set a few lines above.Checklist:
Tested in a ROOT master build (whose
bindings/pyroot/cppjit/test/CMakeLists.txtis the same as on this branch) on AlmaLinux 9 with the dev3 view (gcc 16): before, all 26 cppjit tests fail through ctest; after, all of them pass.