CCOR-13193 - adding test run against oss server in ci - #497
Open
chrishagglund-ship-it wants to merge 10 commits into
Open
CCOR-13193 - adding test run against oss server in ci#497chrishagglund-ship-it wants to merge 10 commits into
chrishagglund-ship-it wants to merge 10 commits into
Conversation
chrishagglund-ship-it
marked this pull request as ready for review
August 19, 2026 17:56
…tched instead of re-fetching it, halving poll requests and fixing its always-empty timeout log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a second integration-test CI job that runs the suite against plain Conductor
OSS, alongside the existing authenticated run against the shared Orkes dev server.
scripts/docker-compose-oss.yamlbrings up Conductor OSS + Postgres + httpbin;scripts/run-integration-oss.shruns the same stack locally.Orkes-Enterprise-only surface (Authorization, Secrets, Schema, Service Registry,
metadata/scheduler tags) is gated behind
CONDUCTOR_SERVER_TYPE=ossand skips onOSS. The Signal API tests do run on OSS, using WAIT-based fixture variants
(
complex_wf_signal_test_ossand friends) — YIELD is Orkes-only, so the existingfixtures never reach a signalable state there. A few call sites need an OSS-specific
path rather than a skip (archiving on delete, the missing
/workflow/{id}/status,create-with-
overwrite); each is gated on OSS on purpose, so the Orkes path stillfails if the real behaviour regresses.
Requires the
E2E_TEST_OSS_CONDUCTOR_VERSIONorg variable, with a repositoryaccess policy that includes this repo. The new job fails fast if it can't resolve
an image tag.
Also fixes three latent bugs in the existing Orkes run
Running against a fresh, single-tenant server surfaced these. All three affect the
integration-testjob too, not just the new one:test_async.pywas clobbering another suite's task def — it registered a bareTaskDefunderpython_integration_test_task, the nametest_workflow_execution.pyruns real workflows against. Those two run asconcurrent CI jobs against one server, so last writer won, and a bare def gets the
server's default 3600s
responseTimeoutSeconds— so a stalled worker held the taskfor an hour and the workflow sat
IN_PROGRESS. It now registers its own def instead.run_workflow_execution_testsnever registered its task def —generate_tasks_defs()was dead code, so the def was whatever another suite leftbehind. Registering it sets
response_timeout_seconds=2(see 1) and makes the suitework on a fresh server.
_wait_for_blocking_taskmatched any in-flight task, but the outerSUB_WORKFLOWflips to
IN_PROGRESSbefore the nested workflow reaches its blocking task, so thesignal raced the real block (intermittent "Expected BLOCKING_TASK, got None" / 404
"Found no blocked task"). It now descends into running sub-workflows and matches
only a non-terminal WAIT/YIELD task.
Also
is_oss()helper instead of 9 open-codedenv reads, 4 of them inverted.
test_task_metadata_service.pygains atearDownClass— its defs used to be leftbehind, so re-runs hit "already exists".
test@conductoross.ioplaceholder csharp-sdk settledon for this ticket, not real employee addresses.
run-integration-oss.shpulls the image unconditionally so a cachedlatestisn'treused; OSS health wait 120s → 180s;
workflow_dispatchgains anoss_conductor_versioninput.