chore: remove deprecated LAMBDA from TaskType - #28
Open
nthmost-orkes wants to merge 1 commit into
Open
Conversation
LAMBDA is deprecated in Conductor (use INLINE instead). Remove it from the TaskType constants and the ALL_TYPES allow-list. The server still supports LAMBDA, but this SDK's TaskType is a builder/validation convenience — not a strict deserialization enum — so removal only steers users off building new LAMBDA tasks and does not affect reading existing workflows. Resolves #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
LAMBDAvalue fromTaskType— both the constant and its entry inALL_TYPES(lib/conductor/workflow/task_type.rb). LAMBDA is deprecated in Conductor; new workflows should useINLINE.Mirrors the Python SDK change in conductor-oss/python-sdk#500 (issue conductor-oss/python-sdk#427).
User impact: Ruby SDK users building workflows will no longer be offered
TaskType::LAMBDAin autocomplete/validation, steering them toward the supportedINLINEtask type instead.Why this is safe here (and why the typed SDKs are excluded)
The Conductor server still supports and emits LAMBDA — it's deprecated, not removed (the
Lambdaexecutor andTaskType.LAMBDAstill exist server-side). This SDK'sTaskTypeis a builder/validation convenience: a set of string constants plus anALL_TYPESallow-list. It is not used to strictly deserialize workflow definitions into a typed enum, so removing the constant does not break reading existing workflows that contain LAMBDA tasks — it only removes the convenience for authoring new ones.For contrast, the strongly-typed SDKs (Java, C#) are intentionally not getting this change: removing a deprecated value from a deserialization enum while the server still emits it would break reading legacy workflow defs.
Resolves #27