Repository navigation
🚨 Update registry.access.redhat.com/ubi9/go-toolset Docker tag to v9 (main) - #3375
Conversation
|
🤖 Finished Review · ✅ Success · Started 2:25 AM UTC · Completed 2:34 AM UTC |
ReviewFindingsHigh
Next steps:
<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiRG9ja2VyZmlsZS5kaXN0IiwibGluZSI6MTl9XX0= --> Previous runReviewFindingsHigh
Low
Info
Next steps:
Previous run (2)Review — ⚠ Changes RequestedSummaryThis automated Renovate PR changes the Findings🔴 High: Go version tagging scheme change risks build correctness (
|
5401302 to
26e07d2
Compare
|
🤖 Finished Review · ✅ Success · Started 2:21 AM UTC · Completed 2:28 AM UTC |
26e07d2 to
fc0a1df
Compare
|
🤖 Finished Review · ✅ Success · Started 2:17 AM UTC · Completed 2:21 AM UTC |
|
🤖 Finished Retro · ✅ Success · Started 5:36 PM UTC · Completed 5:47 PM UTC |
Retro: PR #3375 — Renovate go-toolset major version bump (autoclosed)Timeline
AssessmentReview quality was good. The review agent correctly identified a genuine correctness risk — the tagging scheme change means future Renovate updates would track UBI OS releases instead of Go versions, risking silent toolchain drift. The suggested remediation (verify Go version in the image, reconfigure Renovate to track Go-version-based tags) was actionable and appropriate. The third review was the most comprehensive and well-structured, showing improvement over iterations. The core inefficiency is well-documented. Three review agent runs on a bot PR that no human ever engaged with, followed by a retro agent run on the autoclosed result, consumed resources without driving any outcome. This is the same pattern identified across multiple prior retros. No new proposals — existing issues cover all findingsEvery improvement opportunity surfaced by this PR is already tracked by open issues:
|
fc0a1df to
61e71c9
Compare
|
🤖 Finished Review · ✅ Success · Started 2:47 AM UTC · Completed 2:58 AM UTC Commit: |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
61e71c9 to
db7abb8
Compare
|
<!-- fullsend:risk-assessment --> DetailsBot-authored single-line Dockerfile tag update with minimal change surface, but one protected-path hit and a file with notably high author diversity and churn rate over the past 30-90 days nudge the score to moderate. |
| ## Build | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.26.7@sha256:685ccca486cc2c82b0818d835abecb1aed7a396e76ba416cfc47c28067f5d365 AS build | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.9-1794518352@sha256:4053e919374d739ee6b0007e412d89256b0bd065e0bc690c2b3905bbaab6500e AS build |
There was a problem hiding this comment.
[high] api-contract
The go-toolset image tag changed from a Go-version-based tag (1.26.7) to a RHEL-version-based tag (9.9-1794518352). The project's go.mod requires go 1.26.7. If the new image does not bundle Go 1.26.x, the build will either fail (if the bundled Go is older than what go.mod requires) or silently produce binaries compiled with an unintended Go version. The digest pin ensures reproducibility but does not guarantee Go version compatibility. This tag scheme change makes the Go version opaque from the Dockerfile alone.
Suggested fix: Verify that the image at sha256:4053e919374d739ee6b0007e412d89256b0bd065e0bc690c2b3905bbaab6500e ships Go 1.26.x (e.g., by running podman run --rm registry.access.redhat.com/ubi9/go-toolset:9.9-1794518352@sha256:4053e919374d739ee6b0007e412d89256b0bd065e0bc690c2b3905bbaab6500e go version). If it ships a different Go version, either update go.mod to match or revert to a tag that bundles Go 1.26.x. Consider adding a build-time check (e.g., RUN go version | grep -q go1.26) to catch future mismatches.
This PR contains the following updates:
1.26.7→9.9-1794518352Configuration
📅 Schedule: (UTC)
* 0-3 * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.