Skip to content

chore: pass step outputs through env and fix workflow lint findings #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 4 commits into from
Oct 31, 2026
Merged

chore: pass step outputs through env and fix workflow lint findings #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74de92e
chore: pass step outputs through env and apply zizmor and actionlint …
shenxianpeng Oct 31, 2026
6c25775
chore: run the pre-commit workflow again when a PR title is edited
shenxianpeng Oct 31, 2026
99cd60c
chore: drop per-repo zizmor config and run the fail-fast step in bash
shenxianpeng Oct 31, 2026
4c7b21a
chore: treat checks-failed as a string in the commented-out condition
shenxianpeng Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ updates:
directory: "/"
schedule:
interval: "weekly"
cooldown:
default-days: 7
open-pull-requests-limit: 10
groups:
actions:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
branches: [main]
pull_request:
# edited: check the PR title again after it is changed
types: [opened, synchronize, reopened, edited]
branches: [main]

permissions: {}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Release

on:
release:
branches: [main]
types: [released]
workflow_dispatch:
inputs:
Expand Down
17 changes: 12 additions & 5 deletions .github/workflows/self-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,17 @@ jobs:
extra-args: -std=c++14 -Wall

- name: Fail fast?!
# if: steps.linter.outputs.checks-failed > 0
# if: ${{ !contains(fromJSON('["0", ""]'), steps.linter.outputs.checks-failed) }}
shell: bash
env:
CHECKS_FAILED: ${{ steps.linter.outputs.checks-failed }}
TIDY_CHECKS_FAILED: ${{ steps.linter.outputs.clang-tidy-checks-failed }}
FORMAT_CHECKS_FAILED: ${{ steps.linter.outputs.clang-format-checks-failed }}
run: |
echo "some linter checks failed"
echo "total checks-failed: ${{ steps.linter.outputs.checks-failed }}"
echo "clang-tidy checks-failed: ${{ steps.linter.outputs.clang-tidy-checks-failed }}"
echo "clang-format checks-failed: ${{ steps.linter.outputs.clang-format-checks-failed }}"
echo "total checks-failed: $CHECKS_FAILED"
echo "clang-tidy checks-failed: $TIDY_CHECKS_FAILED"
echo "clang-format checks-failed: $FORMAT_CHECKS_FAILED"
Comment thread
shenxianpeng marked this conversation as resolved.
Resolved
# for actual deployment
# run: exit 1

Expand Down Expand Up @@ -127,6 +132,8 @@ jobs:
step-summary: false

- name: Assert auto-fix committed the formatting changes
env:
FORMAT_CHECKS_FAILED: ${{ steps.linter.outputs.clang-format-checks-failed }}
run: |
set -euo pipefail

Expand Down Expand Up @@ -164,7 +171,7 @@ jobs:
exit 1
fi

failed='${{ steps.linter.outputs.clang-format-checks-failed }}'
failed="$FORMAT_CHECKS_FAILED"
if [ "${failed:-0}" != "0" ]; then
echo "::error title=auto-fix::clang-format still reports $failed issue(s) after auto-fix"
exit 1
Expand Down
Loading