Repository navigation
fix: make poll() and poll_one() check for ready I/O - #419
Closed
TheLingeringWill wants to merge 1 commit into
Closed
TheLingeringWill wants to merge 1 commit into
TheLingeringWill wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
|
An automated preview of the documentation is available at https://419.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-11-14 00:42:52 UTC |
|
GCOVR code coverage report https://419.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-11-14 01:00:04 UTC |
On the reactor backends, poll() and poll_one() returned as soon as the reactor's sentinel was the only entry queued, without polling the reactor. A read whose data had already arrived, or a timer that had expired, stayed pending however many times poll() ran, unless some other handler happened to be queued with the sentinel. The sentinel now makes one non-blocking pass in that case. A pass that reaps completions runs them as before; poll() and poll_one() return once a pass reaps nothing. The pass releases the mutex while this thread holds the sentinel, so a run() thread can park on the condition variable meanwhile. Returning after a pass now wakes a parked peer to take the sentinel, as io_uring does; wait_one() returns the same way and gets the same hand-off. Closes cppalliance#418
TheLingeringWill
force-pushed
the
pr/poll-reaps-ready-io
branch
from
November 14, 2026 00:37
bf3671d to
f06e764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.