Repository navigation
State the shape rules of var and the Run window's args rows
#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,7 +176,7 @@ CodeMirror is a ready-made editor, and the interface isolates it from the rest o | |
|
|
||
| ### The Run window shows what a prompt declares, and its Run button has an empty click handler | ||
|
|
||
| Run > New Run Window runs `workbench.action.newRunWindow`, which opens a `run` panel in the main zone and loads the focused editor's file. The panel posts the prompt's text to the server route `POST /prompts/contract` and draws one row for each front-matter key except `uses`. The owner's rule: "let's keep the UI simple, one row for each thing." | ||
| Run > New Run Window runs `workbench.action.newRunWindow`, which opens a `run` panel in the main zone and loads the focused editor's file. The panel posts the prompt's text to the server route `POST /prompts/contract` and draws one row for each front-matter key except `uses`. For `args` it draws one row for each argument the prompt declares at the top level: a switch for a boolean, a number field for an integer or a number, a text field for a string, and a box of JSON text for a list or an object. A string named `text` gets a multiline box, because `text` is the Engine's name for free text. The owner's rule: "let's keep the UI simple, one row for each thing." | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Document the implicit
Suggested fix
|
||
|
|
||
| The Run button exists so that the window has its final shape. Its click handler is empty because running a prompt from this window is still to be built (section 8). | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exempt
json.nullfrom the userdata rule.This sentence says every userdata raises, but Line 302 explicitly exempts
json.null. The contradiction makes it unclear whether authors can store JSON null invar. State the exception here or reconcile the two rules.