Skip to content

Move the runvil-harness pin to its new history - #214

Merged
vinniefalco merged 1 commit into
cppalliance:masterfrom
vinniefalco:master
Nov 12, 2026
Merged

vinniefalco merged 1 commit into
cppalliance:masterfrom
vinniefalco:master

Conversation

@vinniefalco

@vinniefalco vinniefalco commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

The history of cppalliance/runvil-harness was rebuilt so that it includes the plan and vibe records of the Engine and the Harness. Every commit there has a new id, so the commit this repository pins has to move.

What changed

  • The four pins in the root Cargo.toml (runvil, harness-gateway-client, plugin-web, plugin-mcp) move from 73242996 to 5bca6f9f, the current head of runvil-harness.
  • Cargo.lock follows: the source line of each of the 15 crates from that repository changes, and no package changes version.

Why this is safe

The code at the two commits is the same. The new head differs from the old one only by files under plan/ and vibe/: 156 records and the folder's two ignore files. All 1,094 commits of the first history are in the new one with the same code, author, dates, and message.

The old commit stays reachable in runvil-harness through the tag before-plan-records, so master here keeps building until this merges. The tag goes away after that.

Verification

Run locally on Windows with the new pin, all passing:

  • cargo fmt --all --check
  • cargo clippy on both partitions, with CARGO_BUILD_WARNINGS=deny
  • cargo nextest run --locked on both partitions: 795 passed and 347 passed
  • cargo doc on the workspace partition with RUSTDOCFLAGS="-D warnings", and workshop-server with private items
  • cargo dylint --all
  • cargo xtask tidy, which includes the harness_pin check
  • node --test crates/workshop/ui/test/docs-claims.mjs
  • cargo deny check, cargo audit, and the ring check
  • cargo build --locked -p workshop

Summary by CodeRabbit

  • Chores
    • Aligned the underlying components on a consistent revision. No changes to user-facing features or behavior are specified, and the update does not change component versions or repository locations.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The four Git dependencies runvil, harness-gateway-client, plugin-web, and plugin-mcp now pin revision 5bca6f9fd9b398d5f221a5893570b8085bc283da. Their versions and repository URL remain unchanged.

Changes: Dependency revision update

Layer / File(s) Summary
Update dependency revision
Cargo.toml
The four Git dependencies now use the new revision. Their versions and repository URL remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: gregjkal, drauschenbach

Merge Risk: Minimal · up to 48a4d

The change only moves the harness dependency pin, and the lockfile is consistent with it. No merge-blocking risk was found. The PR description names a different commit than the one actually pinned, so the description should be updated.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Move the runvil-harness pin to its new history" matches the main change. The raw summary and objectives both say four workspace dependency pins in Cargo.toml move from the old runvil-harnes…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "Move the runvil-harness pin to its new history" matches the main change. The raw summary and objectives both say four workspace dependency pins in Cargo.toml move from the old runvil-harness commit to a new commit that has a rebuilt history. The title is specific and is not vague, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 252fb9b7-d029-4241-865e-830a46a9536c
Commits

Reviewing files that changed from the base of the PR and between 3a2d4a4 and 48a4dbc.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1

  • Cargo.toml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The reviewed changes appear safe to merge; no blocking issue was found.

Summary

Moves the runvil-harness pins from 73242996 to 5bca6f9f.

  • Runvil's shared Engine and Harness crates now use the rebuilt history.

Reviews (2) · Last reviewed commit: "Move the runvil-harness pin to its new h..." · Reviewed by Greptile

The history of `runvil-harness` was written again, so the commit that this workspace pins has a new id. The four pins in the root `Cargo.toml` move from `732429962c5873458213bb0072a0828a40ee4fb6` to `5bca6f9fd9b398d5f221a5893570b8085bc283da`, and `Cargo.lock` follows.

- In `Cargo.lock` only the `source` line of each of the 15 crates from that repository changes. No package changes version.
@vinniefalco
vinniefalco merged commit 48a4dbc into cppalliance:master Nov 12, 2026
30 checks passed

This branch was previously deployed

1 inactive deployment
github-pages — 48a4dbc0 Deployed Nov 12, 2026 by vinniefalco via deploy #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant