Skip to content

Name the store effect and build installers from Workshop at 623eb7aa - #217

Merged
vinniefalco merged 2 commits into
cppalliance:masterfrom
vinniefalco:master
Nov 14, 2026
Merged

vinniefalco merged 2 commits into
cppalliance:masterfrom
vinniefalco:master

Conversation

@vinniefalco

@vinniefalco vinniefalco commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Brings this repository in line with the private run store, which landed in cppalliance/runvil-harness#15 and cppalliance/runvil-workshop#23.

Commits

  • Name a store operation in the Engine's list of effects. The Engine definition in AGENTS.md and the paragraph on the Engine in README.md list "a store operation" as the last thing a run asks its caller for. AGENTS.md has the same text as in runvil-harness and runvil-workshop.
  • Build the installers from Workshop at 623eb7aa. rev in [workspace.metadata.workshop] moves seven Workshop commits, to the merge of runvil-workshop#23.

The pin move

  • Workshop at 623eb7aa has this workspace's version, 0.3.0, and toolchain channel, 1.99, so neither changes here.
  • Across the seven commits Workshop changed no build tooling: nothing under gateway-pin/, tools/, or the Tauri configuration, and only a README under crates/build-workshop.
  • The change of rev starts installers.yml, which builds each installer from the pinned commit.

Checks

  • cargo fmt --all --check
  • cargo nextest run --locked --workspace --all-features: 196 passed. The one test that reads a real Workshop checkout ran against 623eb7aa.
  • cargo test -p build-xtask: 99 passed
  • node --test tools/docs-claims.mjs

Not covered

  • No installer was built locally. The installers.yml run on this pull request is the check of the real bundle.

Summary by CodeRabbit

  • Documentation
    • Updated the Engine description to include store operations among the requests it can make and await a response for.
    • Removed references to access to files outside a prelude’s installation as an Engine request in the documentation.

The definition of the Engine in `AGENTS.md` and the paragraph on how the parts fit together in `README.md` each ended the list of what a run asks its caller for with "a file outside a prelude's install". Both now end the list with "a store operation", because every store call of a run is an effect, and a Pack prelude makes no store call while it installs.

Plan: runvil-harness/plan/2026-11-14-1-private-store.plan.md
`rev` in `[workspace.metadata.workshop]` names the Workshop commit `623eb7aa33c84fb3ceb7fc1628845120f607dfb7`, which is seven commits later than the one it named. Workshop at that commit has this workspace's version and toolchain channel, so neither changes here.

- `rev` is the one line that changes.
- The one test that reads a real Workshop checkout ran against that commit and passes. No installer was built on this machine for the change.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The PR updates the Engine request descriptions in AGENTS.md and README.md. It also changes the Workshop Git revision pin in Cargo.toml.

Changes: Engine descriptions

Layer / File(s) Summary
Update Engine request descriptions
AGENTS.md, README.md
The descriptions replace a file outside a prelude’s install with a store operation among the Engine requests. Other listed request types remain in the README description.

Workshop revision pin

Layer / File(s) Summary
Change Workshop revision pin
Cargo.toml
The workspace metadata changes the Workshop Git revision pin from e32d4caaaa60ad03d47fb807daa5d0d4b2c80ec4 to 623eb7aa33c84fb3ceb7fc1628845120f607dfb7.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: Minimal · up to 48b41

This updates Engine documentation wording and moves the Workshop pin to a newer revision. No concrete merge-blocking risk was found; the installer build check on the pull request will confirm the bundle.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names two changes: the store effect wording in the Engine description, and building installers from Workshop at 623eb7aa. The raw summary and objectives confirm both: AGENTS.md and README.md…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names two changes: the store effect wording in the Engine description, and building installers from Workshop at 623eb7aa. The raw summary and objectives confirm both: AGENTS.md and README.md now describe a store operation as an Engine request, and the Cargo.toml workshop rev pin moves to 623eb7aa33c84fb3ceb7fc1628845120f607dfb7. The title is specific and matches the changeset. It is slightly long at 68 characters, but it is clear.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 79a29a40-4832-4777-a05c-6e891cb58ad5
Commits

Reviewing files that changed from the base of the PR and between 003bebd and 48b419b.

Files selected for processing: 3

  • AGENTS.md
  • Cargo.toml
  • README.md

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

Updates the Engine’s effect list and the Workshop commit used to build installers.

  • Installer builds now use Workshop commit 623eb7aa.
  • The Engine descriptions now name store operations as effects.

Reviews (1) · Last reviewed commit: "Build the installers from Workshop at `6..." · Reviewed by Greptile

@vinniefalco
vinniefalco merged commit 48b419b into cppalliance:master Nov 14, 2026
28 checks passed

This branch was successfully deployed

1 active deployment
github-pages — 48b419be Deployed Nov 15, 2026 by vinniefalco via deploy #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant