Repository navigation
Name the store effect and build installers from Workshop at 623eb7aa - #217
Merged
Merged
Conversation
The definition of the Engine in `AGENTS.md` and the paragraph on how the parts fit together in `README.md` each ended the list of what a run asks its caller for with "a file outside a prelude's install". Both now end the list with "a store operation", because every store call of a run is an effect, and a Pack prelude makes no store call while it installs. Plan: runvil-harness/plan/2026-11-14-1-private-store.plan.md
`rev` in `[workspace.metadata.workshop]` names the Workshop commit `623eb7aa33c84fb3ceb7fc1628845120f607dfb7`, which is seven commits later than the one it named. Workshop at that commit has this workspace's version and toolchain channel, so neither changes here. - `rev` is the one line that changes. - The one test that reads a real Workshop checkout ran against that commit and passes. No installer was built on this machine for the change.
[Medium impact] The reviewed changes appear safe to merge.
|
vinniefalco
temporarily deployed
to
github-pages
November 14, 2026 16:50 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this repository in line with the private run store, which landed in cppalliance/runvil-harness#15 and cppalliance/runvil-workshop#23.
Commits
AGENTS.mdand the paragraph on the Engine inREADME.mdlist "a store operation" as the last thing a run asks its caller for.AGENTS.mdhas the same text as inrunvil-harnessandrunvil-workshop.623eb7aa.revin[workspace.metadata.workshop]moves seven Workshop commits, to the merge of runvil-workshop#23.The pin move
623eb7aahas this workspace's version, 0.3.0, and toolchain channel, 1.99, so neither changes here.gateway-pin/,tools/, or the Tauri configuration, and only a README undercrates/build-workshop.revstartsinstallers.yml, which builds each installer from the pinned commit.Checks
cargo fmt --all --checkcargo nextest run --locked --workspace --all-features: 196 passed. The one test that reads a real Workshop checkout ran against623eb7aa.cargo test -p build-xtask: 99 passednode --test tools/docs-claims.mjsNot covered
installers.ymlrun on this pull request is the check of the real bundle.Summary by CodeRabbit