Repository navigation
TS-48500 Gradle plugin: Accept read-only JaCoCo excludes and JUnit engine excludes - #1004
Merged
Merged
Conversation
The plugin appended its default excludes to the build's excludes list in place, so a read-only list such as Kotlin's listOf(...) made applying the plugin fail with an UnsupportedOperationException. It now assigns a new list with the same content and order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Teamscale exempts @test methods from the interface comment check, but it does not resolve the JUnitTest import alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test task action added the impacted test engine to the build's engine excludes in place, so a read-only set such as setOf(...) failed every plain test run. The build-excludes tests now also fail when the plugin stops adding its default excludes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stahlbauer
changed the title
DreierF
approved these changes
Nov 4, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stahlbauer
enabled auto-merge
November 4, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TS-48500.
When a Gradle Kotlin DSL build set the excludes of the JaCoCo task extension to a read-only list (
excludes = listOf(...)), applying the Teamscale Gradle plugin failed withUnsupportedOperationException (no error message). The plugin added its default excludes to that list in place. The test task action did the same with the JUnit Platform engine excludes, souseJUnitPlatform { excludeEngines = setOf(...) }failed every plain test run.Changes
TeamscalePlugin.configureTestTasksassigns a new list, the build's excludes followed by the plugin's defaults, instead of callingaddAllon the build's list. The order is unchanged, and excludes that are null stay null, as before.TestImpactConfigurationActionassigns a new set of engine excludes, the build's engines plus the impacted test engine, instead of callingaddon the build's set.Notes for the reviewer
TeamscalePluginBuildExcludesTest.ktbecause PR TS-46356 Gradle plugin: Make the default excludes match Mockito mocks and Guice fast classes #1003 addsTeamscalePluginDefaultExcludesTest.kt. Both PRs add a CHANGELOG line under the next version, so whichever merges second needs a trivial rebase there.tasks.test { }block, still replaces the plugin's defaults. That was already so for mutable lists; TS-48510 tracks it.🤖 Generated with Claude Code