WmTests: adapt home action tests to current settings - #1349
Open
CeRRiLLo89 wants to merge 1 commit into
Open
Conversation
CeRRiLLo89
marked this pull request as ready for review
September 6, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceKeysConstants.Actionmechanism.LineageSettings.Systemsettings instead of writing removedPhoneWindowManagerbehavior fields directly.Root cause
KeyGestureEventTestsstill configures HOME behavior through test helpers that write:mLongPressOnHomeBehaviormDoubleTapOnHomeBehaviorThose fields are no longer part of the current
PhoneWindowManagerimplementation.The production code now reads HOME actions from:
LineageSettings.System.KEY_HOME_LONG_PRESS_ACTIONLineageSettings.System.KEY_HOME_DOUBLE_TAP_ACTIONusing
DeviceKeysConstants.Action.The tests therefore no longer compile against the current implementation.
Validation
Current base:
71eec03efd654a4d14995b198566df9225015bb1m -j6 WmTestscompleted successfully with this patch.PR #1341 was applied locally only as an independent temporary build dependency because the current base contains a separate natural-rotation WmTests compilation issue.
PR #1341 is not included in this branch.
Runtime execution on the official
raphaelROM was not performed because the locally builtWmTests.apkis signed with the AOSP platform test key, while the installed crDroid framework uses the crDroid platform key. Package verification was not bypassed.This changes test code only; no production behavior is modified.
Stable patch-id:
371ea11a821e2556222e91d24e4699c9eb119311