Repository navigation
code-walkthrough: before/after overview concepts, thread glossary, bump to 1.4.0 - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
define_termstool (max 5, only terms that occur in the answer). Terms are stored with the turn and shown as a dotted underline with a popover (hover, keyboard focus, long-press on touch).Notes
test_cw_ask.py::test_full_turn_is_wrapped_in_bwrap_when_availablefails inside the sandbox, unrelated.Not checked
Nothing was run in a real browser: concept cards, mobile layout, dark mode, popover placement and touch long-press. Real model output for concepts and terms is also untested.