Repository navigation
code-walkthrough: auto glossary, overview/detailed modes, group verdicts, always-on review bar, bump to 1.5.0 - #63
Merged
Merged
Conversation
…cts, always-on review bar, bump to 1.5.0 The page explains its own jargon and lets you review from the pictures alone. - Glossary: a `glossary` step picks up to 12 project terms from the page text. Their first occurrence in each block gets a dotted underline and a hover/focus/long-press definition. Thread replies add their own terms. - Overview: when concept cards exist, the text Overview shrinks to a bold lead; the rest stays in Detailed. Cards are picture first, then a caption, with Before/After/Why collapsed. Pages without concepts are unchanged. - Modes: an Overview/Detailed toggle (default Detailed, remembered per walkthrough). Overview hides diffs and hunk bodies. - Group verdicts: one "Looks good" / "Needs changes" mark per group replaces the per-file "viewed" checkbox. "Looks good" collapses the group's files. - Review bar: always visible on live pages, with Comment / Request changes / Approve. It shows `3/5 checked · 1 needs changes` and highlights the suggested verdict. The dialog pre-fills the summary with the "Needs changes" groups. Approve with open groups warns but never blocks. - Zero-comment submit: the bar sends `direct`, so Approve and Request changes work without any pending review. A review opened only for that submit is deleted if the submit fails. A Comment with no summary and nothing pending is rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page explains its own jargon and lets you review from the pictures alone.
glossarystep picks up to 12 project terms from the page text. Their first occurrence in each block gets a dotted underline and a hover/focus/long-press definition. Thread replies add their own terms.3/5 checked · 1 needs changesand highlights the suggested verdict. The dialog pre-fills the summary with the "Needs changes" groups. Approve with open groups warns but never blocks.direct, so Approve and Request changes work without any pending review. A review opened only for that submit is deleted if the submit fails. A Comment with no summary and nothing pending is rejected.Not tried in a browser: hover and re-marking, mode toggle, chips, bar and dialog, mobile layout. The zero-comment submit was tested against a fake
gh, not real GitHub. Theglossarystep has not run against a real model.