Repository navigation
code-walkthrough: glossary cwd fix, slim review dock, bump to 1.6.0 - #64
Merged
Merged
Conversation
- Glossary step failed on real runs with "cwd is not a directory": _run_glossary did not pass cwd=d/"head" to run_tools like the other steps. Fixed, with a test asserting the cwd - Review bar, Threads pill and the fixed top status strip are now one floating pill: status dot, Threads, and a "Review · N/M" button opening Comment / Request changes / Approve. Each choice opens the same Submit review dialog with the summary field, freeing the top and bottom strips - Review fixes: dialog moved out of the tray, status popover anchored inside the viewport, closes with the thread panel and on Escape, focus returns to the Review button, failed banner opens once, dead nav offset for the old banner removed, content padding for the dock, live.md updated - conftest.py clears CLAUDE_CONFIG_DIR, so test_full_turn_is_wrapped_in_bwrap_when_available no longer depends on the shell environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the glossary step and slims the review controls into one pill
Why
Changes
Tested
Full suite: 1424 passed, 11 skipped. The dock was not exercised in a real browser or at phone width, only render tests and a mockup