Skip to content

sce setup - #339

Merged
davidabram merged 9 commits into
remove-markersfrom
sce-setup
Oct 27, 2026
Merged

davidabram merged 9 commits into
remove-markersfrom
sce-setup

Conversation

@davidabram

Copy link
Copy Markdown
Member

No description provided.

Implement setup access-preference persistence with schema validation, unrelated-key preservation, optimistic concurrency checks, and atomic replacement while retaining file modes. Move the shared atomic-write helper out of Claude telemetry setup and expose the global config path for future setup integration.

Plan: setup-auth-telemetry-consent (T01)

Co-authored-by: SCE <sce@crocoder.dev>
@davidabram
davidabram added this pull request to stack #337 October 21, 2026 13:22
davidabram and others added 8 commits October 21, 2026 15:25
Prepare auth login for the setup flow by carrying telemetry provisioning state alongside rendered output and threading a supplied working directory through config resolution and repository enrollment. Preserve the existing text and JSON output while exposing the telemetry result to callers.

Ref: context/plans/setup-auth-telemetry-consent.md (T02)

Co-authored-by: SCE <sce@crocoder.dev>
Add auth-mode, telemetry-consent, and login prompts to the setup prompter while preserving the existing confirmation wording and defaults. Centralize interactive prompt result handling and document the completed prompt-seam task.

Plan: setup-auth-telemetry-consent (T03)

Co-authored-by: SCE <sce@crocoder.dev>
Prompt for auth mode, telemetry consent, and login intent after existing setup confirmations while honoring persisted values and effective policy locks. Carry only answers made in the current run through SetupDispatch, keeping non-interactive setup unchanged and deferring persistence and login actions to follow-up setup work.

Plan: setup-auth-telemetry-consent.md (T04)

Co-authored-by: SCE <sce@crocoder.dev>
Save auth.mode and telemetry.enabled answers from interactive setup to the global user config before any repository write, preserving unrelated values and refusing invalid or concurrently changed files.

Re-resolve the effective policy for the SCE access report while leaving non-interactive setup and resolver precedence unchanged. Document the user-layer-only contract and complete T05 in the consent plan.

Co-authored-by: SCE <sce@crocoder.dev>
Interactive setup must honor the re-resolved auth policy after saving access preferences, including mandatory login and optional user acceptance. Reuse the auth login flow, render fixed safe outcomes, preserve mandatory failures as auth.setup_login_required, and suppress Claude's pending status only when telemetry was issued. Document the contract and mark the completed task.

Plan: setup-auth-telemetry-consent.md, T06

Co-authored-by: SCE <sce@crocoder.dev>
Interactive setup previously suppressed persisted choices, leaving no supported way to change them. Add `--reconfigure` with conflict validation, persisted defaults, and prompt-suppression reporting while preserving repository/explicit locks and invalid-global behavior. Update setup dispatch, CLI contracts, and plan completion for the new flow.

Plan: setup-auth-telemetry-consent.md, T07

Co-authored-by: SCE <sce@crocoder.dev>
Make Claude setup readiness depend on a valid credential bound to the current repository, using a bounded fail-closed lookup rather than credential issuance in the current run. Refuse to replace symlink-managed global access configuration while preserving unchanged links and report actionable remediation.

Plan: setup-auth-telemetry-consent (T01, T06; AC9)

Co-authored-by: SCE <sce@crocoder.dev>
Avoid opening auth storage or OS credential stores during non-interactive and
target-specific setup while preserving repository authorization reporting for
interactive setup. Gate the lookup on SetupMode and render an explicit
not-checked status for configured Claude telemetry; update the command-surface
and setup/telemetry documentation accordingly.

Plan: setup-auth-telemetry-consent.md (AC9)

Co-authored-by: SCE <sce@crocoder.dev>
@davidabram
davidabram merged commit c0bdae6 into main Oct 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant