Repository navigation
Auth tele impr - #341
Merged
Merged
Auth tele impr#341
Conversation
Prepare the setup access-preference layer for repository-local auth and telemetry answers while preserving the existing global behavior. Share guarded parsing and atomic-write logic across configuration layers, bootstrap repository config files with explicit answers, and add coverage for preservation, no-op, concurrency, symlink, and mode-safety cases. Update durable context to document the repository writer and its current wiring status. Plan: setup-auth-mode-repo-local (T01) Co-authored-by: SCE <sce@crocoder.dev>
Allow a repository telemetry.enabled: true value to enable telemetry unless another layer opts out, so repository-local access answers take effect. Resolve the reported value and source from the layer that decides the opt-in or opt-out, remove the obsolete no_user_consent state and warning, and clarify the not_enabled guidance. Update resolver and rendering tests plus the access-policy documentation and decision record. Complete plan task T02. Plan: `context/plans/setup-auth-mode-repo-local.md` (T02) Co-authored-by: SCE <sce@crocoder.dev>
Keep interactive `auth.mode` and `telemetry.enabled` answers scoped to each repository by reading and persisting them in `.sce/config.json`, while retaining global and explicit policy locks and global-only Claude telemetry withdrawal behavior. Remove global access writes, update setup prompts and reports, and cover saved-answer suppression, layer locks, invalid configs, and symlink protection. Plan: setup-auth-mode-repo-local (T03) Co-authored-by: SCE <sce@crocoder.dev>
Expose the effective repository access policy in `sce doctor`, including a blocking diagnostic when mandatory SCE login is missing and source details for telemetry state. Reuse the non-interactive credential check without creating auth state, and keep the human and JSON reports aligned with focused render coverage. Plan: setup-auth-mode-repo-local (T04) Co-authored-by: SCE <sce@crocoder.dev>
Non-interactive and target-flag setup now reports when the effective access policy requires authentication, without opening auth.db or the credential store. Resolve the policy after installation, preserve exit behavior on resolution failure, and keep interactive login handling unchanged. Plan: setup-auth-mode-repo-local.md T05 Co-authored-by: SCE <sce@crocoder.dev>
Emit one Claude `systemMessage` at `SessionStart` when the repository's effective access policy is `mandatory` and no valid SCE credential is stored. Reuse the existing bounded, fail-closed credential check while keeping model-state persistence and all other hook failures fail-open, so the notice never blocks Claude or gets suppressed by unrelated errors. Plan: setup-auth-mode-repo-local.md (T06, T07) Co-authored-by: SCE <sce@crocoder.dev>
Move Claude session login detection from the model-state CLI hook into the Claude-only sce-info plugin, where interactive session startup can run doctor and log the notice without affecting model-state intake. Rename the plugin identity to SCE, add focused login-notice coverage, and update generated-contract and repository context documentation to reflect the new ownership.
The Claude-only sce-info hook now probes sce --version before doctor, renders a pulsing install prompt when the CLI is unavailable, and logs consolidated git-hook and Claude problem notices. Doctor JSON exposes stable problem kind and target fields so consumers avoid parsing summary text. Stamp generated hook source with the repository CLI version and cover status rendering, doctor metadata, and session notices with tests and documentation. Co-authored-by: SCE <sce@crocoder.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.