deps: bump the moby group across 1 directory with 2 updates - #100
deps: bump the moby group across 1 directory with 2 updates#100dependabot[bot] wants to merge 1 commit into
Conversation
092f751 to
76bddc8
Compare
76bddc8 to
1558087
Compare
Bumps the moby group with 2 updates in the / directory: [github.com/moby/moby/api](https://github.com/moby/moby) and [github.com/moby/moby/client](https://github.com/moby/moby). Updates `github.com/moby/moby/api` from 1.54.2 to 1.55.0 - [Release notes](https://github.com/moby/moby/releases) - [Commits](moby/moby@api/v1.54.2...api/v1.55.0) Updates `github.com/moby/moby/client` from 0.4.1 to 0.5.1 - [Release notes](https://github.com/moby/moby/releases) - [Changelog](https://github.com/moby/moby/blob/v0.5.1/CHANGELOG.md) - [Commits](moby/moby@v0.4.1...v0.5.1) --- updated-dependencies: - dependency-name: github.com/moby/moby/api dependency-version: 1.55.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: moby - dependency-name: github.com/moby/moby/client dependency-version: 0.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: moby ... Signed-off-by: dependabot[bot] <support@github.com>
1558087 to
ef09f41
Compare
There was a problem hiding this comment.
Code Review — head ef09f41
Reviewed head ef09f41 after fetching origin and checking it out detached (the normal gh pr checkout 100 attempt could not establish tracking for the Dependabot ref; the detached checkout matched the requested head). The range is one commit and two changed files: go.mod and go.sum.
Applied .dap/review/engineering.md from directives base 7103d81 and CONTRIBUTING.md from that same base. The referenced PRD.md is absent at that base. Since this is a dependency-only bump, I checked every repository caller of github.com/moby/moby/api and github.com/moby/moby/client and read the relevant Docker runtime implementations, then compared the old and new Moby module sources for the APIs used here. Existing calls and option/result types remain compatible; the client’s only relevant behavioral changes are API-version maximum negotiation and the addition of the unused attestations API, neither of which breaks these callers. No verified findings.
Covered D10/D11 and repository R7/R8 compatibility concerns for the changed dependencies, including API negotiation, build/pull, container lifecycle, exec, inspect/logging, network, volume, and image calls. D1-D9, D12-D14 were not materially touched by this two-file dependency update and were skipped. Tests were not executed per review policy.
Verdict
CLEAN — this round found nothing.
* deps: bump the pending Go module updates Folds the six open dependabot module bumps into one change, taking the latest release of each rather than the version each PR was cut against: - compose-spec/compose-go/v2 2.11.0 -> 2.14.0 (#112) - google/go-containerregistry 0.21.7 -> 0.22.0 (#113 asked for 0.21.9) - moby/moby/api 1.54.2 -> 1.55.0, moby/moby/client 0.4.1 -> 0.5.1 (#100) - golang.org/x/term 0.43.0 -> 0.45.0 (#110) - google.golang.org/protobuf 1.36.11 -> 1.36.12 (#114) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ci: bump the pending GitHub Actions updates All four are majors whose breaking changes are the Node 24 runtime default and an ESM migration; the workflows pass no inputs that the majors removed, and no workflow uses pull_request_target or workflow_run, which is the trigger pair actions/checkout v7 newly refuses to check out fork PRs for. - actions/checkout v6 (ci.yml) and v4 (devcontainer-*.yml) -> v7 (#99) - actions/setup-go v6 -> v7 (#111) - docker/login-action v3 -> v4 (#96) - docker/setup-buildx-action v3 -> v4 (#95) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(compose): refuse the compose lifecycle hooks on the native path compose-go 2.14 adds ServiceConfig.PreStart, so `pre_start` — which 2.11 rejected at schema validation — now loads cleanly. The native orchestrator creates the service container directly and has no ephemeral init-container step, so it dropped the hook silently; and because the hooks are part of the ServiceConfig that ConfigHash covers, editing a hook that never ran read as a config change and stopped and removed the running container, destroying its writable layer. Refused in Plan.Validate via the existing §2.2 unsupported-field mechanism, before any infrastructure side effect. stripForHash drops the three fields as well: the refusal already makes them unreachable there, but a recreation is unrecoverable, so no field the orchestrator does not execute should be able to trigger one if the refusal moves or a caller reaches ConfigHash directly. post_start and pre_stop parsed cleanly under 2.11 and had the same defect, so all three are refused rather than just the one the bump introduced. The shell-out backend is untouched — it delegates to `docker compose`, which implements the hooks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(compose): refuse unsupported fields before building anything The §2.2 refusal ran only inside Orchestrator.Up, which the engine reaches after prepareComposeServiceImage, layerFeatures and buildComposeSidecarImages. A native project using a refused field therefore paid for the primary image and every sidecar build, and left those images tagged, before being told the engine will not run it. Plan.Validate already documents itself as side-effect-free and safe to call before any backend interaction, so the fix is to call it where that matters: straight after compose.Load. The orchestrator's own validation stays as the authoritative one. Native backend only. The shell-out path hands the project to `docker compose`, which implements hooks and other fields the native orchestrator refuses, so validating there would reject projects that work today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: bilby91 <2201079+bilby91@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
|
Superseded by #129, which folded every open dependency bump into one change. This PR was cut against a
@dependabot close |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the moby group with 2 updates in the / directory: github.com/moby/moby/api and github.com/moby/moby/client.
Updates
github.com/moby/moby/apifrom 1.54.2 to 1.55.0Release notes
Sourced from github.com/moby/moby/api's releases.
Commits
b6c53c2Merge pull request #52773 from vvoland/c8d-amd64-variants01115e8Merge pull request #52906 from vvoland/fix-TestContainerWithConflictingNoneNe...b36296fMerge pull request #52913 from thaJeztah/windows_does_statsa81aa78TestContainerWithConflictingNoneNetwork: Extend Windows timeout908a35aMerge pull request #52914 from thaJeztah/no_stderr04d33b5Merge pull request #52912 from thaJeztah/cleanup_GenerateRandomAlphaOnlyString3b2f557Merge pull request #52722 from notandruu/integration/migrate-TestInspectAPIIm...62b3aaeMerge pull request #52901 from vvoland/c8d-imageusage11d3342integration-cli: un-skip stats tests on Windowsa47b1b2Merge pull request #52891 from smerkviladze/attestations-clearer-blob-missing...Updates
github.com/moby/moby/clientfrom 0.4.1 to 0.5.1Release notes
Sourced from github.com/moby/moby/client's releases.
Changelog
Sourced from github.com/moby/moby/client's changelog.
... (truncated)
Commits
3b89d13Bump to v0.5.116225c4Merge pull request #1291 from dotcloud/ensure_mount_commitdd2f0d8Merge pull request #1238 from dotcloud/1237-improve_docker_top-feature0b57e44Merge branch 'master' into 1237-improve_docker_top-featuref2dc492Merge pull request #1342 from dsissitka/patch-4a7ace53Merge pull request #1339 from dhrp/docker-run-d-descriptionc99e8deMerge branch 'cleanup_signal_handling' of https://github.com/calavera/docker ...c06aa62Merge pull request #1306 from dotcloud/1294_fix_wrong_untag_using_id_rmi9ba9983Fixed a couple of minor syntax errors.7d68afbMerge pull request #1209 from zimbatm/upstart-improvements