Skip to content

feat(MBL-2652): make inApp.siteId optional with a pk_ key - #685

Merged
sydneycollins-cio merged 2 commits into
mainfrom
mbl-2652
Oct 27, 2026
Merged

sydneycollins-cio merged 2 commits into
mainfrom
mbl-2652

Conversation

@sydneycollins-cio

@sydneycollins-cio sydneycollins-cio commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

inApp.siteId is now optional, so apps set up with a pk_ key can turn on in-app with inApp: {}.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


Builds are in progress. This comment will be updated when they finish.

  • iOS FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • Android APN: Build failed. See CI job logs to determine the issue and try re-building.
  • iOS FCM: 685.2.0 (29885438)
  • Android APN: 685.2.0 (29885438)

Base automatically changed from feat/native-sdk-5 to main October 26, 2026 20:55
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Shahroz16 Shahroz16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android looks good. One thing to sort out before this merges, inline.

* Workspace site ID. Optional when `cdpApiKey` is a public `pk_` key, which identifies the
* workspace. Pass `inApp: {}` to turn on in-app messaging without one.
*/
siteId?: string;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we hold this until the iOS release with customerio/customerio-ios#1370 is out and move the iOS pin in this PR? On 5.0.0, build(from:) still throws missingSiteId, so inApp: {} type-checks and works on Android, while iOS logs [InApp] Failed to initialize module and starts without in-app. Same gap #664 had.

@mrehan27 mrehan27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__tests__/in-app-site-id.test.ts still says siteId stays required with a pk_ key, and nothing covers inApp: {}. Please update the header and add a case that inApp: {} reaches native initialize as-is.

Follow-up idea: the example app disables the in-app switch without a site ID (example/src/screens/settings.tsx:98-131), so inApp: {} can't be tried there. Allowing it when the key starts with pk_ would help QA.

…n iOS

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sydneycollins-cio
sydneycollins-cio merged commit 82ee722 into main Oct 27, 2026
31 of 32 checks passed
@sydneycollins-cio
sydneycollins-cio deleted the mbl-2652 branch October 27, 2026 19:11
cio-mobile-release Bot pushed a commit that referenced this pull request Oct 27, 2026
## [7.2.0](7.1.0...7.2.0) (2026-10-27)

### Features

* **MBL-2652:** make inApp.siteId optional with a pk_ key ([#685](#685)) ([82ee722](82ee722))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants