Repository navigation
feat(MBL-2652): make inApp.siteId optional with a pk_ key - #685
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. Builds are in progress. This comment will be updated when they finish.
|
e406c32 to
3992522
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
963a65c to
6ef87b5
Compare
Shahroz16
left a comment
There was a problem hiding this comment.
Android looks good. One thing to sort out before this merges, inline.
| * Workspace site ID. Optional when `cdpApiKey` is a public `pk_` key, which identifies the | ||
| * workspace. Pass `inApp: {}` to turn on in-app messaging without one. | ||
| */ | ||
| siteId?: string; |
There was a problem hiding this comment.
Could we hold this until the iOS release with customerio/customerio-ios#1370 is out and move the iOS pin in this PR? On 5.0.0, build(from:) still throws missingSiteId, so inApp: {} type-checks and works on Android, while iOS logs [InApp] Failed to initialize module and starts without in-app. Same gap #664 had.
mrehan27
left a comment
There was a problem hiding this comment.
__tests__/in-app-site-id.test.ts still says siteId stays required with a pk_ key, and nothing covers inApp: {}. Please update the header and add a case that inApp: {} reaches native initialize as-is.
Follow-up idea: the example app disables the in-app switch without a site ID (example/src/screens/settings.tsx:98-131), so inApp: {} can't be tried there. Allowing it when the key starts with pk_ would help QA.
…n iOS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## [7.2.0](7.1.0...7.2.0) (2026-10-27) ### Features * **MBL-2652:** make inApp.siteId optional with a pk_ key ([#685](#685)) ([82ee722](82ee722))
inApp.siteIdis now optional, so apps set up with apk_key can turn on in-app withinApp: {}.MessagingInAppModuleConfig.Builder()when no site ID is set.🤖 Generated with Claude Code