Repository navigation
test: kill escaped mutants - #20
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #20 +/- ##
==========================================
+ Coverage 81.53% 89.70% +8.17%
==========================================
Files 43 43
Lines 1029 1030 +1
==========================================
+ Hits 839 924 +85
+ Misses 190 106 -84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assisted-By: Claude Opus 5.5
…mplate sets Assisted-By: Claude Opus 5.5
…included Assisted-By: Claude Opus 5.5
…k the interceptors The interceptors work around each test, outside its coverage window, so the feature tests that check isolation never counted for them. Assisted-By: Claude Opus 5.5
…lection Assisted-By: Claude Opus 5.5
…nd purger Assisted-By: Claude Opus 5.5
…query log and the wrap driver test(orm): cover the ORM factory defaults and schema source reuse Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
The ignored mutants change nothing observable: the attributes fetched with limit 1 are not repeatable, connections() is only iterated, and comparing the classes of a non-object throws an Error that equals() already turns into false. Assisted-By: Claude Opus 5.5
roxblnfk
force-pushed
the
test/kill-mutants
branch
from
November 20, 2026 18:46
a24eb6d to
ab04520
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Tests only, plus the Infection gate: the mutation score goes from 57.87% (407 escaped of 966) to 92.58% (78 escaped of 1059) on Linux, and
minMsi/minCoveredMsigo from 54 to 90.Unit/HarnessTestruns the package's own Feature and Acceptance suites, and fixture suites undertests/Fixtures/HarnessSuite, in a nested Testo application: isolation modes, purge at suite start,prepare, unreachable and required databases, function tests, the heap check and its opt-outs.HeapIntegrity, thenew-casecommand,CaseGenerator,TemplateSet,SchemaAssert,SqlAssert,QueryAssert,Config,Env,ConnectionPool,TableRenderer,TableBuilder,Purger,Driver/Feature, the driver filters,Layout,QueryLog,OrmFactory,SchemaSourceandClassList.infection.json:limit: 1raised to 2 on attributes that are not repeatable,array_values()inDatabaseInterceptor::connections()(only iterated), and the&&/||swaps inHeapIntegrity::equals()that end in the\Errorit already catches.Review notes
HarnessTest, like the existingOrmPluginTest) kills their mutants.DBvariable test runs in a child process for that reason.HeapIntegrity::equals()catches\Erroraround==on recursive graphs, but before PHP 8.4 that comparison is a fatal error, not an\Error, so a heap holding such a graph kills the run on 8.2 and 8.3; its test is skipped there.DropTablesisolation on a file-based SQLite database,TEMPtables survive from one test to the next, since the purge lists only the main schema's tables (an in-memory database is reconnected and loses them).Config17 (mostly the Codecov plugin wiring, only visible in a coverage run, and spread mutants on single-item lists),FakePDOStatement10,SqlAssert8 (quote fallbacks no driver reaches),ConnectionPool7 (memo-key concatenations that stay unique),Purger6 (MySQL, Postgres and SQL Server arms, unreachable on SQLite),SchemaCompiler4,DatabaseInterceptor3,StubDriver3,TableRenderer3,OrmPlugin2,OrmTestCase2, and one each in 13 other files.Why?
The tests now check what the harness does, not only that it runs, so CI catches a regression in isolation, purging or the assertions.
Checklist