Repository navigation
test: raise line coverage - #22
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #22 +/- ##
==========================================
+ Coverage 89.70% 98.64% +8.93%
==========================================
Files 43 43
Lines 1030 1030
==========================================
+ Hits 924 1016 +92
+ Misses 106 14 -92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No test ran a statement through the wrap drivers or read FakePDO beyond a select, so the mock layer was the least covered part of the harness. Assisted-By: Claude Opus 5.5
…reads Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
roxblnfk
force-pushed
the
test/coverage
branch
from
November 20, 2026 19:53
a341c0a to
edebdc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
FakePDO,TestPDO,TestPDOStatement, the wrap drivers,StubDriver::create()), thePurgerfallback for other drivers,makeCompositeFK(),fetchSchema(), invalid column definitions,SchemaSource::empty()/fromFile(), andOrmTestCase::extractEntity()/assertEntitySynced().Why?
Line coverage comes first, then mutation work resumes on top of it.
Checklist
composer test:unitandcomposer test:sqlitepass locally; the server suites run in CI onlyReview notes
srcleft alone:TestPDOStatement::bindParam()andbindColumn()forward...\func_get_args(), which copies the variable, so the reference is lost. A value changed afterbindParam()never reaches the query, and a variable bound withbindColumn()is never filled. Only SQL Server's LOB binding callsbindParam(), and it executes straight away, so nothing in the harness hits this today. The tests check only the return values of these two methods.Purgerlines 61-64 (MySQL) and 99-111 (SQL Server).Feature/Common/PurgerTestreaches them on those drivers.ContextInjectingInstance::hasInstance(). In Testo, only the bench handler calls it.