CM-71886 uninstall preserve hooks file - #537
Merged
Merged
Conversation
When Cycode's hooks were the only hooks left, uninstall deleted the whole file and with it any unrelated top-level keys (mcpServers, permissions, ...) in a shared settings file such as Claude Code's settings.json. Drop the emptied hooks key and write the remainder back instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…eserve-hooks-file
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
The user-scope Claude Code path is built from Path.home() at import time, which pyfakefs does not intercept on Python 3.9, so the test only passed where a real ~/.claude/settings.json happened to exist. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
omer-roth
approved these changes
Sep 2, 2026
Ilanlido
enabled auto-merge (squash)
September 2, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the hooks file on uninstall instead of unlinking it
When Cycode's hooks were the only hooks left, uninstall deleted the whole file and with it any unrelated top-level keys (mcpServers, permissions, ...)
in a shared settings file such as Claude Code's settings.json. Drop the emptied hooks key and write the remainder back instead.