Repository navigation
update: optimize broadcaster by lazily computing cert entry bytes - #128
Conversation
Merge changes for 1.10 into master branch
Fix bug in kafka implementation that caused double client registration
d-Rickyy-b
left a comment
d-Rickyy-b
left a comment
There was a problem hiding this comment.
Sorry for the inconvenience but could you please recreate the PR towards the dev branch? I am trying to keep unpublished changes in dev and have master/main on the latest published version or release candidate.
Also see the comment regarding the implementation.
|
I plan to do something similar, but much different |
| } | ||
|
|
||
| func entryBytesComputer(entry *models.Entry) func(subType SubscriptionType) ([]byte, error) { | ||
| return func(subType SubscriptionType) ([]byte, error) { |
There was a problem hiding this comment.
What's the benefit of using a closure here instead of just keeping the switch/case statement as before? I currently only see one additional function call instead of having the switch/case directly within the loop.
There was a problem hiding this comment.
Ah silly me, took care of it now.
|
@d-Rickyy-b shouldn't this PR have been squashed before merging? |
|
Yes, definitely should have been squashed. I only noticed after I merged. Welp. |
optimise broadcaster by lazily computing cert entry bytes