Skip to content

chore(agents): centralize instruction surfaces - #1084

Merged
d-oit merged 3 commits into
mainfrom
chore/issue-1050-agent-surface
Nov 3, 2026
Merged

d-oit merged 3 commits into
mainfrom
chore/issue-1050-agent-surface

Conversation

@d-oit

@d-oit d-oit commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Generate CLAUDE.md, GEMINI.md, and QWEN.md from canonical AGENTS.md plus declared addenda, with an explicit generated-source header.
  • Generate and validate skill labeler globs from .agents/manifest.json; validate relative directory and per-skill link layouts.
  • Preserve existing broken-skill-link and AGENTS.md validation, reject manifest paths outside the repository, and track managed Claude skill links while keeping other Claude-local state ignored.
  • Update setup, ADR 029, manifest documentation, and Plan 194 with the verified S1–S3 status.

Related Issue(s): Fixes #1050

Testing Performed

  • ./scripts/setup-skills.sh
  • ./scripts/validate-skills.sh
  • bats tests/agent-surface-generated.bats tests/generate-skills-docs.bats tests/setup-skills.bats tests/validate-skills.bats — 33 tests passed.
  • ./scripts/quality_gate.sh — all local quality gates passed after review fixes.
  • GitHub CI: Quality Gate, Unit Tests, Build, Coverage, Codacy, CodeQL, security checks, YAML, shellcheck, and Vercel passed. E2E was skipped by the existing change filter; this PR does not touch UI or critical user workflows.
  • Mutation probes: generated drift, labeler globs, per-skill link target, legacy strategy, removed validators, and out-of-repository path writes were exercised; each defect caused the targeted check to fail and passed after restoration.

Code Review

Reviewed all 29 changed files after CI. No unaddressed P1/P2 findings. The review restored the existing skill-link and AGENTS.md checks, contained manifest paths to the repository, and fixed clean-checkout tracking for Claude skill links. Adversarial probes confirmed the new regressions fail under the injected defects.

Decisions

  • Claude/Gemini/Qwen retain relative per-skill symlinks; Cursor/Windsurf use relative directory symlinks. Manifest values now name each scope explicitly.
  • generate-skills-docs.py remains the catalog renderer invoked by setup; agent-surface.py exposes only sync and validate.
  • .claude/ local state remains ignored except manifest-managed skill links, preventing clean-checkout drift for future skills.

All applicable checks are green; the E2E job is conditionally skipped because this change is tooling/documentation only.

Generate tool instructions and labeler globs from the manifest; validate the declared per-client skill-link strategies.

Fixes #1050.
@d-oit d-oit added documentation Documentation improvements chore Maintenance task, tooling update, cleanup skills labels Nov 3, 2026
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-knowledge-studio Ready Ready Preview, v0 Nov 3, 2026 9:10am UTC

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Blocked merge diagnosis — blocked
⏳ Check run(s) still in progress: ["Codacy Static Code Analysis","commitlint","YAML Syntax Validation","Detect Changes","Diagnose Blocked Merge State","GitHub Actions Workflow Validation","Stale Base Guard","Trivy Filesystem Security Scan","Secret Detection","Shell Script Security Analysis","Infrastructure as Code Security","Dependency Advisory Audit","labeler","Analyze (python)","Analyze (actions)","Analyze (javascript-typescript)"]

@github-actions github-actions Bot added ci config tests Related to automated/manual tests scripts labels Nov 3, 2026
@codacy-production

codacy-production Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 107 complexity · 0 duplication

Metric Results
Complexity 107
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Include the four manifest-generated Claude skill symlinks ignored by .gitignore so clean-checkout validation matches the local workspace.

Fixes #1050.
Keep existing skill-link and AGENTS.md checks in validate, reject manifest paths outside the repository, and track generated Claude skill links without exposing other local state.

Fixes #1050.
@d-oit
d-oit merged commit c4af33b into main Nov 3, 2026
29 checks passed
@d-oit
d-oit deleted the chore/issue-1050-agent-surface branch November 3, 2026 09:21

This branch was successfully deployed

1 active deployment
Preview — eb5c630d Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance task, tooling update, cleanup ci config documentation Documentation improvements scripts skills tests Related to automated/manual tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] Make AGENTS.md the single source for agent instructions and fix tool-dir drift

2 participants