Repository navigation
chore(agents): centralize instruction surfaces - #1084
Conversation
Generate tool instructions and labeler globs from the manifest; validate the declared per-client skill-link strategies. Fixes #1050.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Blocked merge diagnosis — blocked |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 107 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Include the four manifest-generated Claude skill symlinks ignored by .gitignore so clean-checkout validation matches the local workspace. Fixes #1050.
Keep existing skill-link and AGENTS.md checks in validate, reject manifest paths outside the repository, and track generated Claude skill links without exposing other local state. Fixes #1050.
Summary
CLAUDE.md,GEMINI.md, andQWEN.mdfrom canonicalAGENTS.mdplus declared addenda, with an explicit generated-source header..agents/manifest.json; validate relative directory and per-skill link layouts.AGENTS.mdvalidation, reject manifest paths outside the repository, and track managed Claude skill links while keeping other Claude-local state ignored.Related Issue(s): Fixes #1050
Testing Performed
./scripts/setup-skills.sh./scripts/validate-skills.shbats tests/agent-surface-generated.bats tests/generate-skills-docs.bats tests/setup-skills.bats tests/validate-skills.bats— 33 tests passed../scripts/quality_gate.sh— all local quality gates passed after review fixes.Code Review
Reviewed all 29 changed files after CI. No unaddressed P1/P2 findings. The review restored the existing skill-link and
AGENTS.mdchecks, contained manifest paths to the repository, and fixed clean-checkout tracking for Claude skill links. Adversarial probes confirmed the new regressions fail under the injected defects.Decisions
generate-skills-docs.pyremains the catalog renderer invoked by setup;agent-surface.pyexposes onlysyncandvalidate..claude/local state remains ignored except manifest-managed skill links, preventing clean-checkout drift for future skills.All applicable checks are green; the E2E job is conditionally skipped because this change is tooling/documentation only.