Skip to content

fix: enable push options on local bare repo - #338

Open
zerone0x wants to merge 1 commit into
dagger:mainfrom
zerone0x:fix-push-options-323
Open

zerone0x wants to merge 1 commit into
dagger:mainfrom
zerone0x:fix-push-options-323

Conversation

@zerone0x

@zerone0x zerone0x commented Mar 26, 2026 •

Copy link
Copy Markdown

Summary

Test plan

  • Existing TestRepositoryOpen/valid_git_repository test passes and now also verifies receive.advertisePushOptions is set
  • go test -short ./... passes (pre-existing failures in TestSelectiveFileStaging are unrelated)

@awdemos

awdemos commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Endorsed for merge.

@awdemos

awdemos commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

@zerone0x friendly ping — this PR currently has merge conflicts with . Could you rebase onto and resolve the conflicts? Once clean I'll re-endorse.

…ions

When users have push.pushOption configured in their git config or use
git versions that send push options by default, pushing to the local
bare repository fails with "the receiving end does not support push
options". Fix by setting receive.advertisePushOptions=true on the bare
repo during initialization.

Fixes dagger#323
@zerone0x
zerone0x force-pushed the fix-push-options-323 branch from 8dd6a55 to 2dfe156 Compare November 1, 2026 17:59
@zerone0x

zerone0x commented Nov 1, 2026

Copy link
Copy Markdown
Author

Rebased onto 2e43e62, conflicts in repository/repository.go resolved; go build ./... and go test -short ./repository/... pass. New head: 2dfe156.

Upstream ensureFork now also handles fork repos that already exist (#362). Because of that, receive.advertisePushOptions=true is now set on every ensureFork call, right after setupConfigInclude, so forks created before this fix get it too. The fork dir is only removed on failure when it was just created.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: git returned error "the receiving end does not support push options" when creating an environment

2 participants