Skip to content

docs: explain shared-nothing profile resolution - #32

Merged
yohamta0 merged 1 commit into
mainfrom
docs/shared-nothing-worker
Aug 28, 2026
Merged

docs: explain shared-nothing profile resolution#32
yohamta0 merged 1 commit into
mainfrom
docs/shared-nothing-worker

Conversation

@yohamta0

@yohamta0 yohamta0 commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

  • document coordinator-side profile and managed-secret resolution
  • distinguish direct providers from Dagu server storage
  • add coordinator-first mixed-version migration guidance
  • cover distributed profile behavior in worker and UI guides

Testing

  • pnpm build
  • pnpm validate:examples
  • git diff --check

Summary by cubic

Documents how runtime profiles and managed secrets resolve for distributed runs: the owning coordinator resolves them, while direct secret providers resolve on the worker where the DAG executes.

Migration

  • Upgrade every coordinator to a coordinator-side resolution release before draining or stopping workers.
  • Keep existing worker mounts until coordinators are upgraded; remove server data and DAG-directory mounts only after workers have been reconfigured.

Written for commit 252f281. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Documentation
    • Updated shared-filesystem worker migration steps and mount requirements.
    • Documented runtime profile and secret handling for distributed runs, including child DAG behavior.
    • Clarified that workers do not need profile copies, secret stores, or server data mounts.
    • Added guidance for TLS/mTLS when coordinator traffic crosses untrusted networks.
    • Updated profile and secrets documentation with worker deployment references.

Workers now resolve runtime profiles and managed secrets through the coordinator. Document the storage boundary, direct-provider requirements, and coordinator-first migration order.
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ddbfe5f8-09a4-4043-8207-4215a7c1bb0c

📥 Commits

Reviewing files that changed from the base of the PR and between 9cf3cf6 and 252f281.

📒 Files selected for processing (5)
  • server-admin/distributed/workers/shared-filesystem.md
  • server-admin/distributed/workers/shared-nothing.md
  • web-ui/profiles.md
  • writing-workflows/runtime-profiles.md
  • writing-workflows/secrets.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The documentation updates revise shared-filesystem migration steps and document how coordinators resolve and transmit runtime profiles and secrets during distributed runs.

Changes

Distributed worker documentation

Layer / File(s) Summary
Shared-filesystem migration sequence
server-admin/distributed/workers/shared-filesystem.md
The worker contract now includes profiles and Dagu-managed secrets. Migration steps now upgrade and bind coordinators before draining workers, remove worker mounts later, preserve coordinator state, and configure peer TLS or mTLS when required.
Distributed profiles and secrets
server-admin/distributed/workers/shared-nothing.md, writing-workflows/runtime-profiles.md, writing-workflows/secrets.md, web-ui/profiles.md
The documentation describes coordinator-managed profile and secret resolution, child DAG workspace behavior, direct provider requirements on workers, and gRPC transfer of managed values. Related documentation links and a Kubernetes deployment comment were updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 252f2

This documentation update clarifies distributed profile and secret resolution and migration guidance without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: documenting shared-nothing profile resolution. It is concise and related to the broader documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/shared-nothing-worker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
dagu-sh-docs 252f281 Aug 28 2026, 10:23 AM

@yohamta0
yohamta0 merged commit d994967 into main Aug 28, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant