Repository navigation
Conversation
Requires SeriousProton GameServerProxy::isListening(). Refs daid#1036. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
SeriousProton#319 has been merged, so this should build now. Could the CI be re-run when you have a moment? 🤖 Generated with Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on daid/SeriousProton#319, which adds
GameServerProxy::isListening(). Merge that first; until then this does not compile against SeriousProton master, so CI here will fail.runProxyServernow keeps the proxy in aP<GameServerProxy>; if!isListening()it logsProxy server failed to listen on port N, exiting., destroys the proxy and returns 1 instead of running the main loop with nobody able to connect (e.g. port already in use). Useful for scripts/service managers that startproxy=....Fixes #1036.
Tested (Windows 11, MSVC, RelWithDebInfo, EE branch built against the SP branch)
EmptyEpsilon.exe proxy=listen:0:x:<port>, 15 s timeout:Failed to listen on TCP port: 36664,Proxy server failed to listen on port 36664, exiting.Not tested
Linux/macOS; connect-to-host proxy mode (
proxy=host:port:...); a real client connecting through the proxy; non-exclusive occupiers on Windows (SO_REUSEADDR lets bind succeed); full test suite/CI (none on the fork).🤖 Generated with Claude Code