Skip to content

58_race: fix station comms errors and text - #2925

Open
dj803 wants to merge 1 commit into
daid:masterfrom
dj803:fix/2294-race-text
Open

dj803 wants to merge 1 commit into
daid:masterfrom
dj803:fix/2294-race-text

Conversation

@dj803

@dj803 dj803 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Hello! Some of the points in #2294, plus errors I met while walking the station comms headlessly.

Cause / change (7 insertions, 5 deletions)

  • Docked comms error "index nil comms_data" (:2377): getWeaponCost()/handleWeaponRestock() read the global comms_data; set it from comms_target.comms_data.
  • Docking status showed raw true/false: now yes/no (reusing the existing station-comms strings).
  • "Race Length: %f" showed 6 decimals: %.1f.
  • "What type of ordnance?" menu had no Back: added.
  • %i given a fractional raceStartDelay raised "number has no integer representation": wrapped in math.ceil.

Not changed: the beep (#2294e): sa_58_beep.ogg is a valid 0.2 s file, about -15 dB, so I could not show it is silent.

Checks

  • Headless comms walk on master: before, 2 comms errors (:2377) and an empty ordnance menu; after, no comms errors in the walk.
  • Lua 5.4 syntax parse of scripts/**.lua: 0 failed. Headless 60 s start of scenario_58_race: 0 error lines.
  • GUI (Windows, this branch, Relay hailing a station), undocked: docking services read yes/no, Back returns to the menu, Race Length: 500.0 units, 454 Seconds remain until start of race (integer). Docked: the ordnance list shows Homing and HVLI with prices (no nil error) and a Back button that returns to the station menu.

NOT tested

🤖 Generated with Claude Code

Race Length shows one decimal, docking services show yes/no instead of raw
booleans, the ordnance restock menu gets a Back button, comms_data is set so the
ordnance prices no longer index a nil global, and the seconds-until-start line
no longer formats a fractional number with %i.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant