Repository navigation
Conversation
The database builder formatted the {idx = -1} 'no beam / no tube at this level'
placeholders, indexed an ordnance row that does not exist for the Ender (levels 11
and 12 used row 7 of 6), and compared a missing prox_scan on the Phobos M3P sensor
levels 10-13.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2290 (part a only; b-d are not touched).
Hello! While running 44_outpost headlessly I saw the Ship Yard database build fail for several of the ships listed in #2290 a. Please correct me if this is not the same error.
Cause (
player_ship_upgrade_downgrade_path_scenario_utility.lua){idx = -1}as "no beam/tube at this level"; the description loops then format the missing fields: beams at line 60 (Player Missile Cr.), tubes at line 87 (Benedict, Ender, Kiriya, MP52 Hornet, Striker).prox_scan, so line 279 compared a number with nil.ord = 7, but the Ender ordnance table has 6 rows, so line 133 would index nil (found by reading the table; on master the line 87 error comes first).Change (10 insertions, 6 deletions): skip
idx < 0entries in the beam and tube loops; addprox_scan = 3to Phobos M3P levels 10-13; Enderord = 7->6.The
prox_scan = 3andord = 6values are my best guess from the neighbouring levels; please check them.Checks
playerShipUpgradeDowngradeData()thenpcall(addShipUpgradeInfoToScienceDatabase, name)for each of the 22 templates inupgrade_path(2026-11-13):29df4600(control):87); Phobos M3P (:279); Player Missile Cr. (:60)scripts/**.lua(the engine's own Lua): 0 failed.NOT tested
prox_scan/ordvalues are right.🤖 Generated with Claude Code