Repository navigation
Conversation
p.setWarpDrive(true) passed the boolean as self, so onNewPlayerShip errored (spaceship.lua:555 attempt to index a boolean) for MP52 Hornet, Phobos M3P, Player Fighter and ZX-Lindworm, and setPlayers stopped before setting maxRepairCrew and the prev*/healthy* fields. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! While testing another change to
scenario_49_allies.luaI hit an error when creating some player ships.Problem
setPlayers()callsp.setWarpDrive(true)/p.setJumpDrive(true)with a dot, sotruebecomesself. Creating an MP52 Hornet, Phobos M3P, Player Fighter or ZX-Lindworm logsonNewPlayerShip callback function error: api/entity/spaceship.lua:555 attempt to index a boolean value (local 'self'), andsetPlayersstops before it setsmaxRepairCrew,cargoand theprev*/healthy*fields. Later update code then compares those nils.Change (4 insertions, 4 deletions):
.->:on those 4 calls.Checks
scenario_49_allies.lua, one player ship of each type created, state read 25 ticks later:master logged 4 callback errors; this branch none.
spaceship.lua:555callback error; this branch logs no errors and the ship appears in Select ship.precheck.sh(Lua 5.4 syntax parse ofscripts/**.lua): 107 files, 0 failed.NOT tested
hasWarpDrive()/hasJumpDrive()read back).🤖 Generated with Claude Code