fix(skills): make skill loading explicit and repeatable - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the Agent Skills tool from
activate_skilltoskill, declare its text output schema, and return full instructions on every read. Bumpagentkit-tool-skillsto 0.10.8 and update the umbrella dependency and documentation. Replace the timing-sensitive Runlet concurrency probe with deterministic barrier synchronization.Motivation
Consumers that run the skill tool behind a composition boundary must forward its result for the instructions to reach model context. The previous activation framing and missing output schema encouraged callers to treat the operation as a one-time side effect; session deduplication then made accidentally discarded instructions unavailable on retry.
The existing concurrency test relied on a bounded yield loop, so a slow scheduler could complete one probe before the other entered and report a false failure.
Impact
The advertised tool name changes to
skill, so consumers with hard-codedactivate_skilllookups must update. Repeated reads now return the complete skill instructions instead ofSkill already read.Technical details
Compatibility
SkillRegistry::reset_activationsremains as a deprecated no-op for patch-release source compatibility.Deterministic concurrency check
The Runlet scheduling test now holds both independent calls at a two-party barrier. A five-second timeout still fails promptly if the calls are actually serialized.
Validation
cargo test -p agentkit-tool-skills,cargo check -p agentkit --features tool-skills, andcargo test -p agentkit-tool-compose --all-featurespass. The formerly flaky concurrency test passed 30 consecutive targeted runs, andmdbook build booksucceeds.