Skip to content

Main - #78

Merged
daocha merged 2 commits into
developfrom
main
Sep 30, 2026
Merged

Main#78
daocha merged 2 commits into
developfrom
main

Conversation

@daocha

@daocha daocha commented Sep 30, 2026

Copy link
Copy Markdown
Owner

No description provided.

daocha and others added 2 commits September 21, 2026 23:36
* Fix Claude Code multi-question reply interaction (#71)

  - Replace Claude text-based choice detection with `AskUserQuestion` requests over the bidirectional CLI control protocol while preserving existing Codex and Copilot behavior.
  - Add initialization, request-response correlation, cancellation, and connection error handling without adding an SDK dependency or changing the Python requirement.
  - Render multiple questions with single-choice and multiple-choice selections, submission validation, and English and Chinese interface text.
  - Forward typed replies and new questions directly to the waiting Claude request instead of queuing them behind unanswered buttons.
  - Scope typed replies to the active session, validate callback chat ownership, and expire question controls after completion, dismissal, cancellation, or abort.
  - Keep the control channel open for background follow-up turns and suppress stall warnings while waiting for user input.
  - Prevent control, system, and subagent events from replacing the main Claude answer during output parsing.

* Update JSON translations and README

* Fix numbered instructions being misidentified as reply choices

  - Require explicit selection language instead of broad phrases such as `go with`, `should I`, or `would you like me to`.
  - Exclude option labels when searching for selection prompts so instructions containing `choose one` do not create buttons.
  - Invalidate previous reply-option tokens when a new message arrives while preserving tokens belonging to other chats.
  - Add regression coverage for instructional lists, generic offers to help, and the reported `go with it` false positive that displayed only steps 2 and 3.
  - Verify that ignoring reply buttons and asking an unrelated question delivers the follow-up response and expires the previous choices.
  - Validation: 420 runtime and router tests passed; all 22 runtime tests passed after adding the session-specific regression.

* Fix generated commit validation and execution (#72)

  - Support `--only` and standalone commits.
  - Reject invalid generated commands before staging.
  - Request shorter generated commit messages.
  - Add regression coverage for long commands, multiple message paragraphs, and unrelated staged files.
  - Validation: 445 tests passed.

---

Co-authored-by: DCHA Agent <259406208+dcha-agent@users.noreply.github.com>
@daocha
daocha merged commit 2b07d43 into develop Sep 30, 2026
6 checks passed
@daocha
daocha deleted the main branch September 30, 2026 12:37
@daocha
daocha restored the main branch September 30, 2026 12:38

This branch was successfully deployed

1 active deployment
pypi — 6cf4610b Deployed Sep 30, 2026 by daocha via pypi-publish #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant