Skip to content

SRE-2257 ci: no proxy option for docker - #16551

Merged
daltonbohning merged 39 commits into
masterfrom
grom72/sre-2257-no-proxy-for-docker
Nov 25, 2025
Merged

daltonbohning merged 39 commits into
masterfrom
grom72/sre-2257-no-proxy-for-docker

Conversation

@grom72

@grom72 grom72 commented Jun 28, 2025 •

Copy link
Copy Markdown
Contributor

DAOS_NO_PROXY variable is used for the list of hosts/network that should not be accessed via proxy.

The variable is propagated to Dockers build procedure via pipeline-lib #472

Requires:

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

grom72 added 27 commits June 27, 2025 12:07
Skip-func-test: true
Skip-test: true
Skip-unit-tests: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-build: false
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Cancel-prev-buil: false

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-test: true
Skip-unit-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-test: true
Skip-unit-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-test: true
Skip-unit-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Skip-test: true
Skip-unit-tests: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@github-actions

github-actions Bot commented Jun 28, 2025 •

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-2257

@grom72
grom72 force-pushed the grom72/sre-2257-no-proxy-for-docker branch from 1ccaccb to be07305 Compare June 28, 2025 22:23
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-16551/7/display/redirect

Skip-test: true
Skip-unit-tests: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
grom72 force-pushed the grom72/sre-2257-no-proxy-for-docker branch from d9ae3b1 to 6c2aa28 Compare June 29, 2025 13:24
Priority: 2

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
grom72 force-pushed the grom72/sre-2257-no-proxy-for-docker branch from 6c2aa28 to 5d9f788 Compare June 29, 2025 13:25
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16551/17/execution/node/1595/log

@grom72
grom72 marked this pull request as ready for review June 30, 2025 18:32
@grom72
grom72 requested a review from a team as a code owner June 30, 2025 18:32
JohnMalmberg
JohnMalmberg previously approved these changes Jun 30, 2025

@JohnMalmberg JohnMalmberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the the library command is removed before landing.

…proxy-for-docker

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
There is no need to use unset HTTPS_PROXY as proxy is selectively
disabled for preconfigured list of hosts.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72 grom72 changed the title sre 2257 no proxy for docker SRE-2257 ci: no proxy option for docker Jul 16, 2025
Final validation on VMs only.
Skip-func-hw-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
grom72 requested a review from JohnMalmberg July 17, 2025 12:10
@grom72

grom72 commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

Assuming the the library command is removed before landing.

Done: c572687

…proxy-for-docker

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
…proxy-for-docker

Only limited tests scope to confirm that Dockers are properly used and
provide proper results

Skip-unit-test-memcheck: true

Allow-unstable-test: true

Skip-fault-injection-test: true

Skip-func-hw-test: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

…proxy-for-docker

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>

@JohnMalmberg JohnMalmberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if the differences between repo-helper-el[8,9] and future 10 are big enough to keep them separate instead of using a generic el file?

@grom72
grom72 requested a review from a team November 24, 2025 09:59
@daltonbohning
daltonbohning merged commit 75fb15c into master Nov 25, 2025
60 checks passed
@daltonbohning
daltonbohning deleted the grom72/sre-2257-no-proxy-for-docker branch November 25, 2025 17:42
daltonbohning pushed a commit that referenced this pull request Apr 20, 2026
Use NO_PROXY to bypass an https proxy when accessing local artifactory.

Backport of: #16551 #17522

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Ryon Jensen <ryon.jensen@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants