Skip to content

DAOS-17357 rebuild: dmg helpers for rebuild stop/start commands - #16819

Closed
kccain wants to merge 7 commits into
masterfrom
kccain/daos_17357_proto
Closed

kccain wants to merge 7 commits into
masterfrom
kccain/daos_17357_proto

Conversation

@kccain

@kccain kccain commented Sep 6, 2025

Copy link
Copy Markdown
Contributor

Also, remove the corresponding original fault injection controls (DAOS_REBUILD_ADMIN_STOP and DAOS_REBUILD_ADMIN_START) from the rebuild engine implementation and tests. The simple rebuild test (daos_test -v) uses the helper functions/commands, and no longer the fault injections.

Restore the rebuild_ults() logic so that it does not live / loop forever (a change that was done earlier to accommodate the faults).

Features: rebuild
Allow-unstable-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
Features: control
Allow-unstable-test: true
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
…olrbld-startstop

Features: control
Allow-unstable-test: true
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@github-actions

github-actions Bot commented Sep 6, 2025

Copy link
Copy Markdown

Ticket title is 'interactive rebuild stop/start: engine integration with MS control plane'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-17357

@kccain
kccain force-pushed the kccain/daos_17357_proto branch from b379273 to e2e28fe Compare September 6, 2025 14:55
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@daos-stack daos-stack deleted a comment from daosbuild3 Sep 6, 2025
@kccain
kccain force-pushed the kccain/daos_17357_proto branch from e2e28fe to 9ea3c49 Compare September 6, 2025 15:00
@daosbuild3

daosbuild3 commented Sep 6, 2025 •

Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16819/3/testReport/

An instance of rare/intermittent known failure https://daosio.atlassian.net/browse/DAOS-17416

@daosbuild3

daosbuild3 commented Sep 7, 2025 •

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16819/3/testReport/

daos_test/dfuse.py failures are an instance of known issue https://daosio.atlassian.net/browse/DAOS-17758

tanabarr
tanabarr previously approved these changes Sep 7, 2025
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16819/3/testReport/

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16819/3/execution/node/1648/log

Also, remove the corresponding original fault injection controls
(DAOS_REBUILD_ADMIN_STOP and DAOS_REBUILD_ADMIN_START) from the
rebuild engine implementation and tests. The simple rebuild test
(daos_test -v) uses the helper functions/commands, and no longer
the fault injections.

Restore the rebuild_ults() logic so that it does not live / loop
forever (a change that was done earlier to accommodate the faults).

Features: rebuild
Allow-unstable-test: true

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
Base automatically changed from tanabarr/control-poolrbld-startstop to master September 16, 2025 23:25
@johannlombardi
johannlombardi dismissed tanabarr’s stale review September 16, 2025 23:25

The base branch was changed.

@johannlombardi

Copy link
Copy Markdown
Contributor

PR #16686 is now landed. Please rebase. Thanks.

Features: rebuild
Allow-unstable-test: true

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
@kccain
kccain force-pushed the kccain/daos_17357_proto branch from 9ea3c49 to 2bc7be7 Compare September 17, 2025 03:45
Features: rebuild
Allow-unstable-test: true

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
@kccain
kccain force-pushed the kccain/daos_17357_proto branch from 54102e1 to 0e35ae3 Compare September 17, 2025 04:07
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16819/7/execution/node/1294/log

@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16819/7/testReport/

@kccain
kccain removed the request for review from tanabarr September 22, 2025 16:21
@kccain

kccain commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

I'm working on #16890 instead of this one for DAOS-17357

@kccain kccain closed this Oct 31, 2025
@kccain
kccain deleted the kccain/daos_17357_proto branch October 31, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants