Skip to content

DAOS-623 cq: no copyright check for documentation - #16832

Merged
daltonbohning merged 2 commits into
masterfrom
grom72/DAOS-623-no-copyright-check-in-md-files
Sep 22, 2025
Merged

daltonbohning merged 2 commits into
masterfrom
grom72/DAOS-623-no-copyright-check-in-md-files

Conversation

@grom72

@grom72 grom72 commented Sep 10, 2025 •

Copy link
Copy Markdown
Contributor

Expecting that documentation (*.md, *.txt) contains copyright header leads to false positives in GHA copyright check on GitHub.

There is no file (*.md, *.txt) except licenses texts and third parts' README that contain a Copyright header.

An example is here:
https://github.com/daos-stack/daos/actions/runs/17446346476/job/49541721540?pr=16768#step:3:12
Copyright Information not found in: docs/dev/development.md

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Expecting that documentation (*.md, *.txt) contains copyright header
leads to false positives in GHA copyright check on GitHub.

There is no file (*.md, *.txt) except licenses texts and third parts'
README that contain a Copyright header.

Doc-only: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@github-actions

Copy link
Copy Markdown

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.4,request_for_2.6.5'
https://daosio.atlassian.net/browse/DAOS-623

daltonbohning
daltonbohning previously approved these changes Sep 10, 2025
Comment thread utils/cq/check_update_copyright.sh Outdated
Doc-only: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
@grom72
grom72 requested a review from a team September 22, 2025 18:23
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 22, 2025
@daltonbohning
daltonbohning merged commit 03737be into master Sep 22, 2025
33 of 35 checks passed
@daltonbohning
daltonbohning deleted the grom72/DAOS-623-no-copyright-check-in-md-files branch September 22, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

4 participants