Skip to content

DAOS-17788 test: Fix recovery/pool_list_consolidation.py test_lost_al… - #16880

Merged
daltonbohning merged 11 commits into
masterfrom
makito/DAOS-17788
Oct 6, 2025
Merged

daltonbohning merged 11 commits into
masterfrom
makito/DAOS-17788

Conversation

@shimizukko

Copy link
Copy Markdown
Contributor

…l_rdb

The test should remove rdb-pool from all ranks from all nodes, but it was only removing it from one of the two ranks in a node even though the test uses dual engine. Fix it to remove from both ranks.

Remove unnecessary system start step.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_lost_all_rdb

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

…l_rdb

The test should remove rdb-pool from all ranks from
all nodes, but it was only removing it from one of
the two ranks in a node even though the test uses
dual engine. Fix it to remove from both ranks.

Remove unnecessary system start step.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_lost_all_rdb

Signed-off-by: Makito Kano <makito.kano@hpe.com>
@github-actions

Copy link
Copy Markdown

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-17788

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
@shimizukko
shimizukko marked this pull request as ready for review September 24, 2025 04:06
@shimizukko
shimizukko requested review from a team as code owners September 24, 2025 04:06
dinghwah
dinghwah previously approved these changes Sep 24, 2025
Comment thread src/tests/ftest/recovery/pool_list_consolidation.py Outdated
Comment thread src/tests/ftest/recovery/pool_list_consolidation.py Outdated
Comment thread src/tests/ftest/recovery/pool_list_consolidation.py Outdated

@phender phender left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Dalton's requested changes and have added some optional feedback.

Comment thread src/tests/ftest/recovery/pool_list_consolidation.py Outdated
Comment thread src/tests/ftest/recovery/pool_list_consolidation.py Outdated
Comment thread src/tests/ftest/recovery/pool_list_consolidation.py
Handle rdb_pool_paths as a list instead of hard-coding
the two paths separately.

Use get_engine_values("scm_mount") to directly get the
two pool paths.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb test_lost_majority_ps_replicas
Signed-off-by: Makito Kano <makito.kano@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb test_lost_majority_ps_replicas
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb test_lost_majority_ps_replicas
Signed-off-by: Makito Kano <makito.kano@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

The test is failing with different issue.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
Signed-off-by: Makito Kano <makito.kano@hpe.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
@daosbuild3

Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
Signed-off-by: Makito Kano <makito.kano@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
Signed-off-by: Makito Kano <makito.kano@hpe.com>
kip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
@daosbuild3

Copy link
Copy Markdown
Collaborator

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium: false
Test-tag: test_lost_all_rdb
@shimizukko
shimizukko requested a review from a team October 2, 2025 20:52
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 6, 2025
@daltonbohning
daltonbohning merged commit 69e9736 into master Oct 6, 2025
35 checks passed
@daltonbohning
daltonbohning deleted the makito/DAOS-17788 branch October 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

5 participants