Skip to content

DAOS-17977 vos: new parameter acts for sys_db_trav_cb_t - #16896

Merged
gnailzenh merged 1 commit into
masterfrom
Nasf-Fan/DAOS-17977
Oct 9, 2025
Merged

gnailzenh merged 1 commit into
masterfrom
Nasf-Fan/DAOS-17977

Conversation

@Nasf-Fan

@Nasf-Fan Nasf-Fan commented Sep 22, 2025 •

Copy link
Copy Markdown
Contributor

db_traverse() calls vos_iterate() to traverse the VOS_ITER_AKEY for related sysdb table. For each found item, it handles it via sys_db_trav_cb_t() that may remove such item from related sysdb table, such as for some CHK cleanup use case. If that happened, We will notify vos_iterate() logic via set "VOS_ITER_CB_DELETE" flag in the "acts" parameter; otherwise some item(s) in related sysdb table may be skipped in subsequent iteration. For CHK use case, that may affect new check instance to reset automatically.

Test-tag: cat_recov

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions

Copy link
Copy Markdown

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - CR9: Failure assert_rc_equal src/tests/suite/daos_cr.c:1861 DER_INVAL(-1003) != DER_SUCCESS(0) and then CR10 - CR28 '
Status is 'In Progress'
Labels: 'ci_master_daily,daily_test'
https://daosio.atlassian.net/browse/DAOS-17977

@Nasf-Fan
Nasf-Fan force-pushed the Nasf-Fan/DAOS-17977 branch 2 times, most recently from 5b7eeb3 to 5978919 Compare September 23, 2025 02:21
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16896/3/execution/node/1391/log

db_traverse() calls vos_iterate() to traverse the VOS_ITER_AKEY
for related sysdb table. For each found item, it handles it via
sys_db_trav_cb_t() that may remove such item from related sysdb
table, such as for some CHK cleanup use case. If that happened,
We will notify vos_iterate() logic via set "VOS_ITER_CB_DELETE"
flag in the "acts" parameter; otherwise some item(s) in related
sysdb table may be skipped in subsequent iteration. For CHK use
case, that may affect new check instance to reset automatically.

Test-tag: cat_recov

Signed-off-by: Fan Yong <fan.yong@hpe.com>
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16896/5/execution/node/624/log

@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16896/5/execution/node/624/log

PoolMembershipTest.test_dangling_rank_entry failed for DAOS-18018, not related with the patch.

@Nasf-Fan
Nasf-Fan marked this pull request as ready for review September 28, 2025 02:14
@Nasf-Fan
Nasf-Fan requested review from a team as code owners September 28, 2025 02:14

@daltonbohning daltonbohning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest changes LGTM but is this really meant to run with

Test-tag: cat_recov

Instead of

Features: cat_recov

@Nasf-Fan

Copy link
Copy Markdown
Contributor Author

ftest changes LGTM but is this really meant to run with

Test-tag: cat_recov

Instead of

Features: cat_recov

I want to only run test cases with tags=cat_recov (that are under src/tests/ftest/recovery/), then which one I should use? @daltonbohning , thanks!

@Nasf-Fan
Nasf-Fan requested a review from a team September 30, 2025 10:09
@daltonbohning

daltonbohning commented Sep 30, 2025 •

Copy link
Copy Markdown
Contributor

I want to only run test cases with tags=cat_recov (that are under src/tests/ftest/recovery/), then which one I should use? @daltonbohning , thanks!

Test-tag: cat_recov is the way to do that, but do the src/bio and src/vos changes not affect any other tests or areas?

@Nasf-Fan

Nasf-Fan commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

I want to only run test cases with tags=cat_recov (that are under src/tests/ftest/recovery/), then which one I should use? @daltonbohning , thanks!

Test-tag: cat_recov is the way to do that, but do the src/bio and src/vos changes not affect any other tests or areas?

No, the new parameter in the patch is useless for src/bio and src/vos related changes.

@Nasf-Fan

Nasf-Fan commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

test_dangling_rank_entry failed for DAOS-18018, not related with the patch.

@gnailzenh
gnailzenh merged commit af4049c into master Oct 9, 2025
40 of 42 checks passed
@gnailzenh
gnailzenh deleted the Nasf-Fan/DAOS-17977 branch October 9, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants