Repository navigation
Conversation
- track both the number of errors and warnings per target - reset status (counters and rc) at each step so they do not affect each other - do not fail iteration. Callbacks always have to return 0. A corrupted node does not have to stop the iteration. We cannot continue processing nodes down the failed path. - do not return a code from the `xxx_process()` functions. It is always ignored anyway. Make sure the code is recorded in the status though. - report the pool validation result always, not only on success. - refactor collecting statuses from targets so all: rc, errors num and warnings num are passed to the reporting function - refactor the report printing functions to accomodate all aspects of the status (rc, errors_num and warnings_num) - fix one CK_PRINTF (not an error) -> CK_PRINTF_ERR (error) - a couple minor fixes where not a correct return code was printed. Skip-func-vm: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-leap-15-rpms: true Skip-func-hw-test: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'dlck: fix rc, errors and warnings num handling' |
Doc-only: true skip-cancel-previous-builds: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Nasf-Fan
requested changes
Oct 21, 2026
- rename dlck_xstream_status_set_rc -> dlck_status_set_rc - rename dlck_xstream_status_set -> dlck_status_set - make dlck_status_set reset rc of the input status - make dlck_report_results' total account for rcs from targets - revert random change in conts_process Skip-func-vm: true Skip-fault-injection-test: true Skip-test-el-9.6-rpms: true Skip-test-leap-15-rpms: true Skip-func-hw-test: true Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
Nasf-Fan
previously approved these changes
Oct 23, 2026
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xxx_process()functions. It is always ignored anyway. Make sure the code is recorded in the status though.Skip-func-vm: true
Skip-fault-injection-test: true
Skip-test-el-9.6-rpms: true
Skip-test-leap-15-rpms: true
Skip-func-hw-test: true
Steps for the author:
After all prior steps are complete: