Repository navigation
DAOS-19795 vos: resume recx enumeration at lowest overlap - #19329
Merged
Merged
Conversation
A recx enumeration resumes from an anchor holding the first unpacked visible extent. evt_iter_probe_find() binary searches the visible extents with an overlap-only compare and returns whichever entry it hits first. If the anchor extent overlaps several entries (the tree was aggregated differently than when the anchor was taken, e.g. the anchor came from another replica, or aggregation above the enumeration epoch split the extent), the hit can be in the middle and the entries before it are silently skipped. Slide to the lowest overlapping entry (highest for reverse iteration) before returning. Visible extents are disjoint and sorted, so the overlapping entries are contiguous. Add VOS438 to reproduce the aggregation split case. Run it alone with: PMEMOBJ_CONF=sds.at_create=0 vos_tests -S /dev/shm/vos -a -f VOS438 Signed-off-by: Xuezhao Liu <xuezhao.liu@hpe.com>
liuxuezhao
requested review from
Nasf-Fan,
NiuYawei,
gnailzenh and
wangshilong
October 20, 2026 09:03
liuxuezhao
changed the title
|
Ticket title is 'VOS recx enumerate possibly lost recx when race with vos aggregation' |
Nasf-Fan
approved these changes
Oct 20, 2026
NiuYawei
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recx enumeration resumes from an anchor holding the first unpacked visible extent. evt_iter_probe_find() binary searches the visible extents with an overlap-only compare and returns whichever entry it hits first. If the anchor extent overlaps several entries (the tree was aggregated differently than when the anchor was taken, e.g. the anchor came from another replica, or aggregation above the enumeration epoch split the extent), the hit can be in the middle and the entries before it are silently skipped.
Slide to the lowest overlapping entry (highest for reverse iteration) before returning. Visible extents are disjoint and sorted, so the overlapping entries are contiguous.
Add VOS438 to reproduce the aggregation split case. Run it alone with:
PMEMOBJ_CONF=sds.at_create=0 vos_tests -S /dev/shm/vos -a -f VOS438
Steps for the author:
After all prior steps are complete: