Repository navigation
[1.18] cherrypick queue fix - #169
Merged
JoshVanL merged 1 commit intoOct 2, 2026
Merged
Conversation
…xiting (dapr#168) * add test Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * add fix Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
JoshVanL
approved these changes
Oct 2, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The locking fix closes the identified race and includes targeted regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Backports the queue processor lost-wakeup fix from PR #168.
Changes:
- Drains the running marker while holding the queue lock.
- Adds concurrent regression coverage.
| File | Description |
|---|---|
events/queue/processor.go |
Prevents queued items from becoming stranded. |
events/queue/processor_lostwakeup_test.go |
Stress-tests concurrent enqueue and loop exit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherrypick #168