Repository navigation
crypto/spiffe/trustanchors/file: handle transient failed reload attempts - #171
Merged
Merged
Conversation
Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Core retry and CA/JWT atomicity behaviors lack direct test coverage.
2 open findings
What changed in this PR
Improves trust-anchor reload resilience while preserving the last valid state.
Changes:
- Retries transient reload failures.
- Applies CA and JWT updates atomically.
- Tests recovery after malformed CA content.
| File | Description |
|---|---|
file.go |
Adds retry and atomic update logic. |
file_test.go |
Verifies failed reload retention and recovery. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
approved these changes
Oct 13, 2026
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.